Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add [ PersianAssetPickerTextDelegate ] asset_picker_text_delegate… #608

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ho3einTahan
Copy link

This pull request adds Persian (Farsi) localization to the Asset Picker, implementing a new delegate class PersianAssetPickerTextDelegate.

@AlexV525
Copy link
Member

Persian is not supported by the Talkback unfortunately, so you need to additionally redirect the semantic delegate to another on Android. Example:

@override
AssetPickerTextDelegate get semanticsTextDelegate {
if (Platform.isAndroid) {
return const EnglishAssetPickerTextDelegate();
}
return this;
}

@AlexV525
Copy link
Member

Also, please provide a screen record using the picker with the new text delegate with VoiceOver enabled.

@Ho3einTahan
Copy link
Author

Ho3einTahan commented Jul 23, 2024

thanks for for your response .
i will fix it .

@Ho3einTahan Ho3einTahan reopened this Jul 30, 2024
@AlexV525
Copy link
Member

AlexV525 commented Aug 1, 2024

Also, please provide a screen record using the picker with the new text delegate with VoiceOver enabled.

@Ho3einTahan
Copy link
Author

i don't have ios device

@AlexV525
Copy link
Member

Do you have a macOS device then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants