Announce a breaking change of added dispose().
#9397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit d0cd593): https://flutter-docs-prod--pr9397-polina-c-dispose-h8iaiomp.web.app (expires Mon, 25 Sep 2023 18:16:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ba327eec813901cac8396c4f458b02288624ab |
5 tasks
polina-c
changed the title
dispose().
polina-c
requested review from
sfshaza2,
atsansone and
parlough
as code owners
atsansone
approved these changes
Sep 15, 2023
Comment on lines
25
to
27
| If you got error like `Once you have called dispose() on a <class name>, it can no longer be used.`, | ||
| and the error is raised for your code, | ||
| update the code to call `dispose()' only in cases when your code created the object. |
There was a problem hiding this comment.
issue: Write as shorter sentences per GSG.
Suggested change
| If you got error like `Once you have called dispose() on a <class name>, it can no longer be used.`, | |
| and the error is raised for your code, | |
| update the code to call `dispose()' only in cases when your code created the object. | |
| If the following error was raised for your code, | |
| update the code to call `dispose()' only in cases when your code created the object. | |
| ```nocode | |
| Once you have called dispose() on a <class name>, it can no longer be used. | |
| ``` |
There was a problem hiding this comment.
Please fix the grammar:
If you encounter the following error, then check for
that condition:
Once you have called dispose() on a <class name>, it can no longer be used.
There was a problem hiding this comment.
Shams, in most cases, the code should not be removed, but condition should be added. So, it should be fixed, not removed.
atsansone
added
the
st.RFM.%
sfshaza2
reviewed
Sep 15, 2023
Comment on lines
25
to
27
| If you got error like `Once you have called dispose() on a <class name>, it can no longer be used.`, | ||
| and the error is raised for your code, | ||
| update the code to call `dispose()' only in cases when your code created the object. |
There was a problem hiding this comment.
Please fix the grammar:
If you encounter the following error, then check for
that condition:
Once you have called dispose() on a <class name>, it can no longer be used.
Co-authored-by: Anthony Sansone <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
kenzieschmoll
approved these changes
Sep 15, 2023
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Sep 19, 2023
atsansone
pushed a commit
that referenced
this pull request
Sep 21, 2023
parlough
removed
the
st.RFM.%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: https://docs.google.com/document/d/1ec5djPP14b1u93O9fHrJJf3gbONay1nV4sBV2-XXOIw/edit?resourcekey=0-CFEu4HWAW8yP0knhoVfKxQ
This announce is added as already released, because we are adding
disposealready long time and some of the changes may be already released: flutter/devtools#3951Tech writers, please do not merge this before tech sign off. @goderbauer , can you review please?