-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Updates component theme normalization breaking changes #12057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Updates component theme normalization breaking changes #12057
Conversation
Visit the preview URL for this PR (updated for commit 71e4def): https://flutter-docs-prod--pr12057-migration-guide-for-bottom-hdj5mq0n.web.app |
…arTheme, BottomAppBarTheme and InputDecorationTheme Add BottomAppBarTheme normalization to align with Flutter Material's component theme conventions
c81091b
to
7cd1fb9
Compare
…component theme conventions
7cd1fb9
to
3e92ead
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
src/content/release/breaking-changes/component-theme-normalization-updates.md
Outdated
Show resolved
Hide resolved
```dart | ||
final BottomAppBarThemeData bottomAppBarTheme = Theme.of(context).bottomAppBarTheme; | ||
final BottomAppBarThemeData bottomAppBarTheme = BottomAppBarTheme.of(context); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also add a section to mention the change when we want to create ThemeData
or use ThemeData.copyWith
like this
Add
BottomAppBarTheme
normalization update to align with Flutter Material's component theme conventions.Presubmit checklist