Skip to content

Updates component theme normalization breaking changes #12057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

huycozy
Copy link
Member

@huycozy huycozy commented May 22, 2025

Add BottomAppBarTheme normalization update to align with Flutter Material's component theme conventions.

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@huycozy huycozy self-assigned this May 22, 2025
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented May 22, 2025

Visit the preview URL for this PR (updated for commit 71e4def):

https://flutter-docs-prod--pr12057-migration-guide-for-bottom-hdj5mq0n.web.app

…arTheme, BottomAppBarTheme and InputDecorationTheme

Add BottomAppBarTheme normalization to align with Flutter Material's component theme conventions
@huycozy huycozy force-pushed the Migration-guide-for-bottom-app-bar-theme-normalization-2 branch 3 times, most recently from c81091b to 7cd1fb9 Compare May 22, 2025 14:40
@huycozy huycozy force-pushed the Migration-guide-for-bottom-app-bar-theme-normalization-2 branch from 7cd1fb9 to 3e92ead Compare June 2, 2025 10:27
@huycozy huycozy requested review from Piinks, QuncCccccc and a team June 3, 2025 08:16
@huycozy huycozy marked this pull request as ready for review June 3, 2025 08:17
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

```dart
final BottomAppBarThemeData bottomAppBarTheme = Theme.of(context).bottomAppBarTheme;
final BottomAppBarThemeData bottomAppBarTheme = BottomAppBarTheme.of(context);
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also add a section to mention the change when we want to create ThemeData or use ThemeData.copyWith like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants