Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new surface provider camerax PR url #11227

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

ThibaultBee
Copy link
Contributor

@ThibaultBee ThibaultBee commented Oct 4, 2024

The current URL https://github.com/flutter/flutter/packages/pull/7044 does not exist, it should be https://github.com/flutter/packages/pull/7044 instead

Description of what this PR is changing or adding, and why:

In page about the new surface provider:
The URL of this camera_android_camerax PR https://github.com/flutter/flutter/packages/pull/7044 does not exist, it should be flutter/packages#7044 instead.

Issues fixed by this PR (if any):

None

PRs or commits this PR depends on (if any):

None

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@ThibaultBee ThibaultBee requested review from sfshaza2, parlough and a team as code owners October 4, 2024 08:40
Copy link

google-cla bot commented Oct 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sfshaza2
Copy link
Contributor

/gcbrun

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 242be57):

https://flutter-docs-prod--pr11227-patch-1-pnxs5grs.web.app

@sfshaza2 sfshaza2 merged commit 40a348a into flutter:main Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants