Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_markdown] Make custom table column alignments work when text wraps #8340

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

andrechalella
Copy link
Contributor

This PR complements PR #7327 (Fix table column alignment), making the table column custom alignment keep working even when text wraps.

Ironically, setting Wrap.alignment wasn't enough, we needed to correct each Text.textAlign in the function _mergeInlineChildren(). Basically, this PR is a major refactor of said function, ensuring that the loop runs to completion even when there is a single widget in the children (thus remaking the widget with the correct textAlign).

This fixes flutter/flutter#160746.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@andrechalella
Copy link
Contributor Author

I fixed whatever failed checks I could, I feel the remaining ones have little to do with the PR itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment in table still doesn't work (when text wraps)
1 participant