-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-create templates/app
, add deprecation notices for app_shared
and skeleton
.
#8336
Open
matanlurey
wants to merge
2
commits into
main
Choose a base branch
from
copy-app-shared-as-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+10.7 KB
...pp/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+295 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+406 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+450 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+282 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+462 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+704 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+406 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+586 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+862 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+862 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.63 KB
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+762 Bytes
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.2 KB
...es/app/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.38 KB
...pp/ios.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+68 Bytes
...plates/app/ios.tmpl/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+68 Bytes
...tes/app/ios.tmpl/Runner/Assets.xcassets/LaunchImage.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+68 Bytes
...tes/app/ios.tmpl/Runner/Assets.xcassets/LaunchImage.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+101 KB
...ates/app/macos.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.55 KB
...lates/app/macos.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+520 Bytes
...plates/app/macos.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+13.8 KB
...lates/app/macos.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.04 KB
...plates/app/macos.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+35.6 KB
...lates/app/macos.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.17 KB
...plates/app/macos.tmpl/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_64.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.46 KB
packages/flutter_template_images/templates/app/web/icons/Icon-maskable-192.png
Oops, something went wrong.
Binary file added
BIN
+20.5 KB
packages/flutter_template_images/templates/app/web/icons/Icon-maskable-512.png
Oops, something went wrong.
Binary file added
BIN
+33 KB
packages/flutter_template_images/templates/app/windows.tmpl/runner/resources/app_icon.ico
Binary file not shown.
Binary file added
BIN
+5.91 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/LargeTile.scale-100.png
Oops, something went wrong.
Binary file added
BIN
+7.25 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/LargeTile.scale-125.png
Oops, something went wrong.
Binary file added
BIN
+9.35 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/LargeTile.scale-150.png
Oops, something went wrong.
Binary file added
BIN
+14.2 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/LargeTile.scale-200.png
Oops, something went wrong.
Binary file added
BIN
+41.5 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/LargeTile.scale-400.png
Oops, something went wrong.
Binary file added
BIN
+1.4 KB
...images/templates/app/winuwp.tmpl/runner_uwp/Assets/LockScreenLogo.scale-200.png
Oops, something went wrong.
Binary file added
BIN
+1.78 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/SmallTile.scale-100.png
Oops, something went wrong.
Binary file added
BIN
+2.46 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/SmallTile.scale-125.png
Oops, something went wrong.
Binary file added
BIN
+2.91 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/SmallTile.scale-150.png
Oops, something went wrong.
Binary file added
BIN
+3.63 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/SmallTile.scale-200.png
Oops, something went wrong.
Binary file added
BIN
+7.87 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/SmallTile.scale-400.png
Oops, something went wrong.
Binary file added
BIN
+6.71 KB
...e_images/templates/app/winuwp.tmpl/runner_uwp/Assets/SplashScreen.scale-100.png
Oops, something went wrong.
Binary file added
BIN
+7.71 KB
...e_images/templates/app/winuwp.tmpl/runner_uwp/Assets/SplashScreen.scale-125.png
Oops, something went wrong.
Binary file added
BIN
+9.9 KB
...e_images/templates/app/winuwp.tmpl/runner_uwp/Assets/SplashScreen.scale-150.png
Oops, something went wrong.
Binary file added
BIN
+15 KB
...e_images/templates/app/winuwp.tmpl/runner_uwp/Assets/SplashScreen.scale-200.png
Oops, something went wrong.
Binary file added
BIN
+45.5 KB
...e_images/templates/app/winuwp.tmpl/runner_uwp/Assets/SplashScreen.scale-400.png
Oops, something went wrong.
Binary file added
BIN
+2.89 KB
...ges/templates/app/winuwp.tmpl/runner_uwp/Assets/Square150x150Logo.scale-100.png
Oops, something went wrong.
Binary file added
BIN
+2.91 KB
...ges/templates/app/winuwp.tmpl/runner_uwp/Assets/Square150x150Logo.scale-125.png
Oops, something went wrong.
Binary file added
BIN
+4.51 KB
...ges/templates/app/winuwp.tmpl/runner_uwp/Assets/Square150x150Logo.scale-150.png
Oops, something went wrong.
Binary file added
BIN
+6.08 KB
...ges/templates/app/winuwp.tmpl/runner_uwp/Assets/Square150x150Logo.scale-200.png
Oops, something went wrong.
Binary file added
BIN
+13.6 KB
...ges/templates/app/winuwp.tmpl/runner_uwp/Assets/Square150x150Logo.scale-400.png
Oops, something went wrong.
Binary file added
BIN
+697 Bytes
...inuwp.tmpl/runner_uwp/Assets/Square44x44Logo.altform-unplated_targetsize-16.png
Oops, something went wrong.
Binary file added
BIN
+15.2 KB
...nuwp.tmpl/runner_uwp/Assets/Square44x44Logo.altform-unplated_targetsize-256.png
Oops, something went wrong.
Binary file added
BIN
+1.5 KB
...inuwp.tmpl/runner_uwp/Assets/Square44x44Logo.altform-unplated_targetsize-32.png
Oops, something went wrong.
Binary file added
BIN
+2.36 KB
...inuwp.tmpl/runner_uwp/Assets/Square44x44Logo.altform-unplated_targetsize-48.png
Oops, something went wrong.
Binary file added
BIN
+1.57 KB
...mages/templates/app/winuwp.tmpl/runner_uwp/Assets/Square44x44Logo.scale-100.png
Oops, something went wrong.
Binary file added
BIN
+1.85 KB
...mages/templates/app/winuwp.tmpl/runner_uwp/Assets/Square44x44Logo.scale-125.png
Oops, something went wrong.
Binary file added
BIN
+2.46 KB
...mages/templates/app/winuwp.tmpl/runner_uwp/Assets/Square44x44Logo.scale-150.png
Oops, something went wrong.
Binary file added
BIN
+3.16 KB
...mages/templates/app/winuwp.tmpl/runner_uwp/Assets/Square44x44Logo.scale-200.png
Oops, something went wrong.
Binary file added
BIN
+6.62 KB
...mages/templates/app/winuwp.tmpl/runner_uwp/Assets/Square44x44Logo.scale-400.png
Oops, something went wrong.
Binary file added
BIN
+479 Bytes
...s/templates/app/winuwp.tmpl/runner_uwp/Assets/Square44x44Logo.targetsize-16.png
Oops, something went wrong.
Binary file added
BIN
+788 Bytes
...s/templates/app/winuwp.tmpl/runner_uwp/Assets/Square44x44Logo.targetsize-24.png
Oops, something went wrong.
Binary file added
BIN
+1.23 KB
...inuwp.tmpl/runner_uwp/Assets/Square44x44Logo.targetsize-24_altform-unplated.png
Oops, something went wrong.
Binary file added
BIN
+10.2 KB
.../templates/app/winuwp.tmpl/runner_uwp/Assets/Square44x44Logo.targetsize-256.png
Oops, something went wrong.
Binary file added
BIN
+1.1 KB
...s/templates/app/winuwp.tmpl/runner_uwp/Assets/Square44x44Logo.targetsize-32.png
Oops, something went wrong.
Binary file added
BIN
+1.57 KB
...s/templates/app/winuwp.tmpl/runner_uwp/Assets/Square44x44Logo.targetsize-48.png
Oops, something went wrong.
Binary file added
BIN
+1.42 KB
...utter_template_images/templates/app/winuwp.tmpl/runner_uwp/Assets/StoreLogo.png
Oops, something went wrong.
Binary file added
BIN
+2.31 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/StoreLogo.scale-100.png
Oops, something went wrong.
Binary file added
BIN
+3.15 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/StoreLogo.scale-125.png
Oops, something went wrong.
Binary file added
BIN
+3.65 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/StoreLogo.scale-150.png
Oops, something went wrong.
Binary file added
BIN
+4.8 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/StoreLogo.scale-200.png
Oops, something went wrong.
Binary file added
BIN
+10.5 KB
...late_images/templates/app/winuwp.tmpl/runner_uwp/Assets/StoreLogo.scale-400.png
Oops, something went wrong.
Binary file added
BIN
+3.13 KB
...mages/templates/app/winuwp.tmpl/runner_uwp/Assets/Wide310x150Logo.scale-200.png
Oops, something went wrong.
Binary file added
BIN
+3.08 KB
...plate_images/templates/app/winuwp.tmpl/runner_uwp/Assets/WideTile.scale-100.png
Oops, something went wrong.
Binary file added
BIN
+3.14 KB
...plate_images/templates/app/winuwp.tmpl/runner_uwp/Assets/WideTile.scale-125.png
Oops, something went wrong.
Binary file added
BIN
+4.88 KB
...plate_images/templates/app/winuwp.tmpl/runner_uwp/Assets/WideTile.scale-150.png
Oops, something went wrong.
Binary file added
BIN
+6.71 KB
...plate_images/templates/app/winuwp.tmpl/runner_uwp/Assets/WideTile.scale-200.png
Oops, something went wrong.
Binary file added
BIN
+15 KB
...plate_images/templates/app/winuwp.tmpl/runner_uwp/Assets/WideTile.scale-400.png
Oops, something went wrong.
Binary file added
BIN
+2.5 KB
...ges/flutter_template_images/templates/app/winuwp.tmpl/runner_uwp/Windows_TemporaryKey.pfx
Binary file not shown.
Binary file added
BIN
+5.81 KB
packages/flutter_template_images/templates/app/winuwp.tmpl/runner_uwp/resources.pri
Binary file not shown.
10 changes: 10 additions & 0 deletions
10
packages/flutter_template_images/templates/app_shared/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
**DO NOT UPDATE**: This directory is _deprecated_. | ||
|
||
The `skeleton` template is being removed, which as a result means that the | ||
`app_shared` directory is no longer needed (it was used to share template | ||
pieces between `app` and `skeleton`). | ||
|
||
If you are looking to update the `app` template, update | ||
[`templates/app`](../app/) directly. | ||
|
||
See also: <https://github.com/flutter/flutter/issues/160692>. |
5 changes: 5 additions & 0 deletions
5
packages/flutter_template_images/templates/skeleton/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
**DO NOT UPDATE**: This directory is _deprecated_. | ||
|
||
The `skeleton` template is being removed. | ||
|
||
See also: <https://github.com/flutter/flutter/issues/160692>. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without a version bump this won't be usable.