Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dependabot]: Bump com.google.guava:guava from 33.3.1-android to 33.4.0-android in /packages/camera/camera_android_camerax/android #8331

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2024

Bumps com.google.guava:guava from 33.3.1-android to 33.4.0-android.

Release notes

Sourced from com.google.guava:guava's releases.

33.4.0

Maven

<dependency>
  <groupId>com.google.guava</groupId>
  <artifactId>guava</artifactId>
  <version>33.4.0-jre</version>
  <!-- or, for Android: -->
  <version>33.4.0-android</version>
</dependency>

Jar files

Guava requires one runtime dependency, which you can download here:

Javadoc

JDiff

Changelog

  • Exposed additional Java 8 APIs to Android users. (6082782134, 9b0109c662, 6ace8bc8ea, b650b9fe77, c6c268006c, 984f713d76, f9f3fffb87, cdc225474e)
  • base: Deprecated Charsets constants in favor of StandardCharsets. We will not remove the constants, but we recommend using StandardCharsets for consistency. (45e6be2688)
  • base: Added ToStringHelper.omitEmptyValues(). (f5ec2ab85c)
  • collect: Added an optimized copyOf method to TreeRangeMap. (a46565dd1c)
  • collect.testing: Fixed @Require annotations so that features implied by absent features are not also required to be absent. (81be061f85)
  • io: Changed ByteSink and CharSink to no longer call flush() in some cases before close(). This is a no-op for well-behaved streams, which internally flush their data as part of closing. However, we have discovered some stream implementations that have overridden close() to do nothing, including not to flush some buffered data. If this change causes problems, the simplest fix is usually to change the close() override to at least call flush(). (6ace8bc8ea)
  • net: Added HttpHeaders.ALT_SVC and MediaType.CBOR. (503ba429f9, 7c0bf0892d)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.3.1-android to 33.4.0-android.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from camsim99 as a code owner December 18, 2024 21:10
@dependabot dependabot bot added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 18, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 18, 2024
Copy link
Contributor

auto-submit bot commented Dec 18, 2024

auto label is removed for flutter/packages/8331, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2024
@ditman ditman added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Dec 24, 2024
Copy link
Contributor

auto-submit bot commented Dec 24, 2024

auto label is removed for flutter/packages/8331, Failed to merge flutter/packages/8331 with Pull request flutter/packages/8331 could not be merged: Pull Request is not mergeable.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 24, 2024
…roid_camerax/android/com.google.guava-guava-33.4.0-android
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 24, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 24, 2024
Copy link
Contributor

auto-submit bot commented Dec 24, 2024

auto label is removed for flutter/packages/8331, due to - The status or check suite Linux analyze stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux analyze master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ditman
Copy link
Member

ditman commented Dec 24, 2024

The problem is that the pathified analysis script is producing the following diff:

diff --git a/packages/camera/camera/example/pubspec.yaml b/packages/camera/camera/example/pubspec.yaml
index 9f3749514..66087e5b4 100644
--- a/packages/camera/camera/example/pubspec.yaml
+++ b/packages/camera/camera/example/pubspec.yaml
@@ -28,9 +28,15 @@ dev_dependencies:
   integration_test:
     sdk: flutter
 
+
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
+# See https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins
 dependency_overrides:
+
   camera_web:
     path: ../../camera_web
+  camera_android_camerax:
+    path: ../../../../packages/camera/camera_android_camerax
 
 flutter:
   uses-material-design: true

The camera_android_camerax should be added before the existing camera_web override. Which probably should not even be an override. I'm going to remove that override in this PR, so this can land.

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 24, 2024
@auto-submit auto-submit bot merged commit 864e6be into main Dec 24, 2024
77 checks passed
@auto-submit auto-submit bot deleted the dependabot/gradle/packages/camera/camera_android_camerax/android/com.google.guava-guava-33.4.0-android branch December 24, 2024 03:36
@ditman
Copy link
Member

ditman commented Dec 24, 2024

Created issue about the pathified analysis script:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants