[in_app_purchase_storekit] fix finish() not completing #8324
+72
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseHsu
commented
Dec 18, 2024
| @@ -12,12 +12,11 @@ import 'consumable_store.dart'; | |||
| import 'example_payment_queue_delegate.dart'; | |||
|
|
|||
| void main() { | |||
| InAppPurchaseStoreKitPlatform.enableStoreKit2(); | |||
There was a problem hiding this comment.
This is the example app - storekit2 needs to be called before everything else to ensure no transactions get missed.
.../in_app_purchase_storekit/example/shared/RunnerTests/InAppPurchaseStoreKit2PluginTests.swift
Outdated
Show resolved
Hide resolved
.../in_app_purchase_storekit/example/shared/RunnerTests/InAppPurchaseStoreKit2PluginTests.swift
Outdated
Show resolved
Hide resolved
…s into fix-missing-completion
hellohuanlin
approved these changes
Dec 20, 2024
| case .success(): | ||
| finishExpectation.fulfill() | ||
| case .failure(let error): | ||
| XCTFail("FInish purchases should NOT fail. Failed with \(error)") |
…s into fix-missing-completion
LouiseHsu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 7, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 7, 2025
flutter/packages@07ae98c...3fc6b7a 2025-01-07 [email protected] go_router_builder: latest dependencies (flutter/packages#8326) 2025-01-06 [email protected] [go_router] Updates readme to reflect current status (flutter/packages#8374) 2025-01-06 [email protected] [in_app_purchase_storekit] fix finish() not completing (flutter/packages#8324) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
finishTransaction()not properly completed. Also driveby test backfill + small adjustment to example app.fixes flutter/flutter#160148
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).