[ci][web] Run integration tests in wasm. #8111
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
force-pushed
the
run-web-integration-wasm
branch
from
8a28941 to
d6bdc4f
Compare
ditman
commented
Dec 20, 2024
| "--exclude=script/configs/exclude_integration_web_wasm.yaml" | ||
| ] | ||
|
|
||
| # DO NOT PUSH THIS FILE! Temporarily changed to test --wasm without waiting for CI |
| // Give the browser some time to perform DOM operations (for Wasm code) | ||
| await tester.pump(const Duration(milliseconds: 500)); |
There was a problem hiding this comment.
Talk to @eyebrowsoffire about this new delay.
There was a problem hiding this comment.
We discussed this, the skwasm renderer is now async, so it makes sense that there's some timing differences compared to the JS one. Needing this additional delay is probably caused by the tester not being aware of this asynchronicity, and declaring a frame "pumped" before it's really been fully rendered.
packages/url_launcher/url_launcher_web/example/integration_test/link_widget_test.dart
Show resolved
Hide resolved
packages/video_player/video_player/example/integration_test/video_player_test.dart
Outdated
Show resolved
Hide resolved
…ion to test CI before it propagates.
… wasm in all_apps
… different entrypoint each time; I'm not sure prebuilding helps with anything other than pre-fetching deps (?)
ditman
force-pushed
the
run-web-integration-wasm
branch
from
420958b to
598ed80
Compare
The only change to |
ditman
added
the
override: no changelog needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs the integration tests in web packages using Wasm.
(This should fail, because packages need a further migration review like this one)
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.