-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove packages/platform from dependabot config #8099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Landing on red to fix the tree!
As @jmagman correctly suspects, this started failing earlier, but the errors went ignored. Here's an earlier failure: And here's the dependabot failure:
Found it by sifting through this list of failed dependabot runs: |
flutter/packages@b9ac917...b164be3 2024-11-14 [email protected] Remove packages/platform from dependabot config (flutter/packages#8099) 2024-11-14 [email protected] Ignore dependabot minor and patch updates of Kotlin mocking library (flutter/packages#8056) 2024-11-14 [email protected] [google_identity_services_web] Set nonce properly in loadWebSdk(). (flutter/packages#8069) 2024-11-14 [email protected] Roll Flutter (stable) from 6031040 to dec2ee5 (4 revisions) (flutter/packages#8084) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Package was removed in #6898.
However the path was still being passed to dependabot, which made it mad:
https://github.com/flutter/packages/actions/runs/11845225387/job/33010210199
I don't understand why this only started failing on #8044 and not when the package was removed (since it moved that path from one place to another https://github.com/flutter/packages/pull/8036/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28L571)
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.