Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove packages/platform from dependabot config #8099

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 14, 2024

Package was removed in #6898.

However the path was still being passed to dependabot, which made it mad:

ERROR <job_916983349> Error during file fetching; aborting: No files found in /packages/platform/example/android/app

https://github.com/flutter/packages/actions/runs/11845225387/job/33010210199

I don't understand why this only started failing on #8044 and not when the package was removed (since it moved that path from one place to another https://github.com/flutter/packages/pull/8036/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28L571)

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Nov 14, 2024
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Landing on red to fix the tree!

@ditman ditman added emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels Nov 14, 2024
@ditman
Copy link
Member

ditman commented Nov 14, 2024

I don't understand why this only started failing on #8044 and not when the package was removed

As @jmagman correctly suspects, this started failing earlier, but the errors went ignored. Here's an earlier failure:

And here's the dependabot failure:

🤖 ~ starting update ~
Fetching job details
...
updater | 2024/10/31 17:36:55 ERROR <job_909746212> Error during file fetching; aborting: No files found in /packages/platform/example/android/app
...
Dependabot encountered '1' error(s) during execution, please check the logs for more details.
+---------------------------+
|          Errors           |
+---------------------------+
| dependency_file_not_found |
+---------------------------+
Failure running container 7b087bcc3c8793d8403cb0765adc678a83f7a89e[47](https://github.com/flutter/packages/actions/runs/11616982022/job/32351158495#step:3:49)d2561867262766fb826ed0
...
For more information see: https://github.com/flutter/packages/network/updates/909746212 (write access to the repository is required to view the log)
🤖 ~ finished: error reported to Dependabot ~

Found it by sifting through this list of failed dependabot runs:

@auto-submit auto-submit bot merged commit b164be3 into flutter:main Nov 14, 2024
65 of 77 checks passed
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 15, 2024
flutter/packages@b9ac917...b164be3

2024-11-14 [email protected] Remove packages/platform from dependabot config (flutter/packages#8099)
2024-11-14 [email protected] Ignore dependabot minor and patch updates of Kotlin mocking library (flutter/packages#8056)
2024-11-14 [email protected] [google_identity_services_web] Set nonce properly in loadWebSdk(). (flutter/packages#8069)
2024-11-14 [email protected] Roll Flutter (stable) from 6031040 to dec2ee5 (4 revisions) (flutter/packages#8084)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants