Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[many] Ignore NewerVersionAvailable in android lint #7218

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Jul 25, 2024

  • Updates android lint to ignore NewerVersionAvailable
  • Update changelog

Fixes flutter/flutter#152316

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker reidbaker marked this pull request as ready for review July 25, 2024 18:27
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
Copy link
Contributor

auto-submit bot commented Jul 25, 2024

auto label is removed for flutter/packages/7218, due to - The status or check suite Linux_android android_device_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
Copy link
Contributor

auto-submit bot commented Jul 25, 2024

auto label is removed for flutter/packages/7218, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
Copy link
Contributor

auto-submit bot commented Jul 25, 2024

auto label is removed for flutter/packages/7218, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 26, 2024
Copy link
Contributor

auto-submit bot commented Jul 26, 2024

auto label is removed for flutter/packages/7218, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 26, 2024
@auto-submit auto-submit bot merged commit 3d358d9 into main Jul 26, 2024
76 checks passed
@auto-submit auto-submit bot deleted the i152316-ignore-newer-version-available branch July 26, 2024 14:22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 26, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 26, 2024
flutter/packages@19daf6f...3d358d9

2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint  (flutter/packages#7218)
2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162)
2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156)
2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
flutter/packages@19daf6f...3d358d9

2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint  (flutter/packages#7218)
2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162)
2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156)
2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@19daf6f...3d358d9

2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint  (flutter/packages#7218)
2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162)
2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156)
2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewerVersionAvailable gradle lint preventing compilation
3 participants