[google_maps_web] Skip a smaller subset of web tests

[bparrishMines]

This stops skipping all of the web google_maps_flutter tests and only skips the one of the tests on for the platform implementation and all the tests for the app-facing package. I'll continue working on a permanent fix for flutter/flutter#145149.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[stuartmorgan]

I know it'll be a lot more code, but I think it would be better to do something like:

// TODO(bparrishMines): Tests are failing on web due to an error being
// thrown after completion. See https://github.com/flutter/flutter/issues/145149
const bool _skipOnWeb = isWeb;

[ Add skip: _skipOnWeb to every test ]

That way they it'll be obvious both when looking at the test, and from the test run output, that web is skipping tests, vs them being silently skipped in an unusual place.

[ditman]

Yikes! is this also preventing google_maps_flutter_web from running on CI?

[ditman]

It does:

============================================================
|| Not running for packages/google_maps_flutter/google_maps_flutter_web; excluded [@7:02]
============================================================

[stuartmorgan]

I believe they were both failing the same way.

[ditman]

I have a "fix" for _web at least:

• [ci] Re-enable google_maps_flutter_web integration tests. #7269

(The root cause seems to be a bug in the html renderer not letting us adjust the devicePixelRatio)

For the web, I just stripped the DPR overrides from the tests (for now), but in cross-platform tests the DPR overrides probably make more sense.

[ditman]

I think the only tests that need to be disabled are those that set the tester.view.devicePixelRatio AND are running with the html renderer (CHANNEL=stable). Canvaskit seems to not be affected.

[stuartmorgan]

Would they pass if if we just wrapped the call to set devicePixelRatio in an if (!kIsWeb) (with a TODO to remove that condition later)?

[ditman]

I've reenabled the google_maps_flutter_web integration tests here: #7269

I'm almost sure that the issue is related to the html renderer, that crashes when the tests override the DPR of the display (I created an issue for that).

Regardless of what happens to the html renderer, I think we'll be able to reenable the web integration tests in the user-facing package when 3.24 rolls to stable (and we stop using the html renderer for integration tests). We may be also able to restore the DPR overrides that I removed in #7269.

Apologies for arriving late to this party, I just noticed this after we merged a big google maps web migration PR (I had been running the tests locally though).

I'll make sure to link this PR and issue to the cleanup issue as well!

[bparrishMines]

@ditman Thanks for landing #7269. I got distracted by other work and meant to come back to this. Should I close this and allow you to handle the fix once 3.24 lands?

[ditman]

@bparrishMines yep! If you want, you can close this and I'll reenable the tests when all web integration tests run in canvaskit only, as part of flutter/flutter#151869.