fix(test): fix broken tests

flutter · May 6, 2024 · 0a4942c · 0a4942c
1 parent 25de3f8
commit 0a4942c
Show file tree

Hide file tree

Showing 34 changed files with 160 additions and 114 deletions.
diff --git a/.github/workflows/ads_consent_client.yaml b/.github/workflows/ads_consent_client.yaml
@@ -0,0 +1,21 @@
+name: ads_consent_client
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+on:
+  pull_request:
+    paths:
+      - "flutter_news_example/packages/ads_consent_client/**"
+      - ".github/workflows/ads_consent_client.yaml"
+    branches:
+      - main
+
+jobs:
+  build:
+    uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/flutter_package.yml@v1
+    with:
+      flutter_version: 3.16.9
+      working_directory: flutter_news_example/packages/ads_consent_client
+      coverage_excludes: "lib/src/generated/*.dart"
diff --git a/.github/workflows/news_blocks_ui.yaml b/.github/workflows/news_blocks_ui.yaml
@@ -16,6 +16,9 @@ jobs:
   build:
     uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/flutter_package.yml@v1
     with:
-      flutter_version: 3.10.2
+      flutter_version: 3.16.9
       working_directory: flutter_news_example/packages/news_blocks_ui
       coverage_excludes: "lib/src/generated/*.dart"
+      # Due to incompability with custom goldenFileComparator,
+      # reference: flutter_news_example/packages/news_blocks_ui/test/helpers/tolerant_comparator.dart
+      test_optimization: false
diff --git a/flutter_news_example/.vscode/cspell.json b/flutter_news_example/.vscode/cspell.json
@@ -103,6 +103,7 @@
     "serializable",
     "shollister",
     "signup",
+    "sqflite",
     "Sonifications",
     "Stepien",
     "sublist",

diff --git a/flutter_news_example/packages/news_blocks_ui/pubspec.yaml b/flutter_news_example/packages/news_blocks_ui/pubspec.yaml
@@ -14,11 +14,13 @@ dependencies:
     sdk: flutter
   flutter_html: 3.0.0-beta.2
   google_mobile_ads: ^5.0.0
+  html: ^0.15.4
   news_blocks:
     path: ../../api/packages/news_blocks
   path_provider_platform_interface: ^2.0.5
   platform: ^3.1.0
   plugin_platform_interface: ^2.1.3
+  sqflite_common_ffi: ^2.3.2+1
   url_launcher: ^6.1.7
   url_launcher_platform_interface: ^2.1.1
   video_player: ^2.7.0

diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/divider_horizontal.png b/flutter_news_example/packages/news_blocks_ui/test/src/divider_horizontal.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/html_test.dart b/flutter_news_example/packages/news_blocks_ui/test/src/html_test.dart
@@ -4,6 +4,7 @@ import 'package:app_ui/app_ui.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_html/flutter_html.dart' as flutter_html;
 import 'package:flutter_test/flutter_test.dart';
+import 'package:html/dom.dart' as dom;
 import 'package:mocktail/mocktail.dart';
 import 'package:news_blocks/news_blocks.dart';
 import 'package:news_blocks_ui/news_blocks_ui.dart';
@@ -18,9 +19,12 @@ class _MockUrlLauncher extends Mock
 
 class _FakeLaunchOptions extends Fake implements LaunchOptions {}
 
+class _MockDomElement extends Mock implements dom.Element {}
+
 void main() {
   group('Html', () {
     late UrlLauncherPlatform urlLauncher;
+    final domElement = _MockDomElement();
 
     setUpAll(() {
       registerFallbackValue(_FakeLaunchOptions());
@@ -46,44 +50,53 @@ void main() {
     });
 
     group('hyperlinks', () {
-      testWidgets('does not launch the url when it is empty', (tester) async {
+      testWidgets('does not launch the url when it is null', (tester) async {
+        const String? link = null;
         const block = HtmlBlock(
-          content: '<a href="#">flutter.dev</a>',
+          content: '<a href="$link">flutter.dev</a>',
         );
 
         await tester.pumpApp(Html(block: block));
 
-        await tester.tap(
-          find.textContaining('flutter.dev', findRichText: true),
-        );
+        final widget =
+            tester.widget(find.byType(flutter_html.Html)) as flutter_html.Html;
+
+        // workaround as taping a elements is not working.
+        widget.onLinkTap!(link, {}, domElement);
 
         verifyNever(() => urlLauncher.launchUrl(any(), any()));
       });
 
       testWidgets('does not launch the url when it is invalid', (tester) async {
+        const link = '::Not valid URI::';
         const block = HtmlBlock(
-          content: '<a href="::Not valid URI::">flutter.dev</a>',
+          content: '<a href="$link">flutter.dev</a>',
         );
 
         await tester.pumpApp(Html(block: block));
 
-        await tester.tap(
-          find.textContaining('flutter.dev', findRichText: true),
-        );
+        final widget =
+            tester.widget(find.byType(flutter_html.Html)) as flutter_html.Html;
+
+        // workaround as taping a elements is not working.
+        widget.onLinkTap!(link, {}, domElement);
 
         verifyNever(() => urlLauncher.launchUrl(any(), any()));
       });
 
       testWidgets('launches the url when it is a valid url', (tester) async {
+        const link = 'https://flutter.dev';
         const block = HtmlBlock(
-          content: '<a href="https://flutter.dev">flutter.dev</a>',
+          content: '<a href="$link">flutter.dev</a>',
         );
 
         await tester.pumpApp(Html(block: block));
 
-        await tester.tap(
-          find.textContaining('flutter.dev', findRichText: true),
-        );
+        final widget =
+            tester.widget(find.byType(flutter_html.Html)) as flutter_html.Html;
+
+        // workaround as taping a elements is not working.
+        widget.onLinkTap!(link, {}, domElement);
 
         verify(
           () => urlLauncher.launchUrl('https://flutter.dev', any()),
@@ -128,17 +141,15 @@ void main() {
           ),
         );
 
-        expect(
-          find.byWidgetPredicate(
-            (widget) =>
-                widget is flutter_html.Html &&
-                widget.style['h1']!.generateTextStyle() ==
-                    flutter_html.Style.fromTextStyle(
-                      theme.textTheme.displayLarge!,
-                    ).generateTextStyle(),
-          ),
-          findsOneWidget,
-        );
+        final expectedStyle = flutter_html.Style.fromTextStyle(
+          theme.textTheme.displayLarge!.copyWith(letterSpacing: -0.25),
+        ).generateTextStyle();
+
+        final widget =
+            tester.widget(find.byType(flutter_html.Html)) as flutter_html.Html;
+        final style = widget.style['h1']!.generateTextStyle();
+
+        expect(style, expectedStyle);
       });
 
       testWidgets('<h2> tags correctly', (tester) async {
@@ -153,17 +164,15 @@ void main() {
           ),
         );
 
-        expect(
-          find.byWidgetPredicate(
-            (widget) =>
-                widget is flutter_html.Html &&
-                widget.style['h2']!.generateTextStyle() ==
-                    flutter_html.Style.fromTextStyle(
-                      theme.textTheme.displayMedium!,
-                    ).generateTextStyle(),
-          ),
-          findsOneWidget,
-        );
+        final expectedStyle = flutter_html.Style.fromTextStyle(
+          theme.textTheme.displayMedium!.copyWith(letterSpacing: 0),
+        ).generateTextStyle();
+
+        final widget =
+            tester.widget(find.byType(flutter_html.Html)) as flutter_html.Html;
+        final style = widget.style['h2']!.generateTextStyle();
+
+        expect(style, expectedStyle);
       });
 
       testWidgets('<h3> tags correctly', (tester) async {
@@ -178,17 +187,15 @@ void main() {
           ),
         );
 
-        expect(
-          find.byWidgetPredicate(
-            (widget) =>
-                widget is flutter_html.Html &&
-                widget.style['h3']!.generateTextStyle() ==
-                    flutter_html.Style.fromTextStyle(
-                      theme.textTheme.displaySmall!,
-                    ).generateTextStyle(),
-          ),
-          findsOneWidget,
-        );
+        final expectedStyle = flutter_html.Style.fromTextStyle(
+          theme.textTheme.displaySmall!.copyWith(letterSpacing: 0),
+        ).generateTextStyle();
+
+        final widget =
+            tester.widget(find.byType(flutter_html.Html)) as flutter_html.Html;
+        final style = widget.style['h3']!.generateTextStyle();
+
+        expect(style, expectedStyle);
       });
 
       testWidgets('<h4> tags correctly', (tester) async {
@@ -203,17 +210,15 @@ void main() {
           ),
         );
 
-        expect(
-          find.byWidgetPredicate(
-            (widget) =>
-                widget is flutter_html.Html &&
-                widget.style['h4']!.generateTextStyle() ==
-                    flutter_html.Style.fromTextStyle(
-                      theme.textTheme.headlineMedium!,
-                    ).generateTextStyle(),
-          ),
-          findsOneWidget,
-        );
+        final expectedStyle = flutter_html.Style.fromTextStyle(
+          theme.textTheme.headlineMedium!.copyWith(letterSpacing: 0),
+        ).generateTextStyle();
+
+        final widget =
+            tester.widget(find.byType(flutter_html.Html)) as flutter_html.Html;
+        final style = widget.style['h4']!.generateTextStyle();
+
+        expect(style, expectedStyle);
       });
 
       testWidgets('<h5> tags correctly', (tester) async {
@@ -228,17 +233,15 @@ void main() {
           ),
         );
 
-        expect(
-          find.byWidgetPredicate(
-            (widget) =>
-                widget is flutter_html.Html &&
-                widget.style['h5']!.generateTextStyle() ==
-                    flutter_html.Style.fromTextStyle(
-                      theme.textTheme.headlineSmall!,
-                    ).generateTextStyle(),
-          ),
-          findsOneWidget,
-        );
+        final expectedStyle = flutter_html.Style.fromTextStyle(
+          theme.textTheme.headlineSmall!.copyWith(letterSpacing: 0),
+        ).generateTextStyle();
+
+        final widget =
+            tester.widget(find.byType(flutter_html.Html)) as flutter_html.Html;
+        final style = widget.style['h5']!.generateTextStyle();
+
+        expect(style, expectedStyle);
       });
 
       testWidgets('<h6> tags correctly', (tester) async {
@@ -253,17 +256,15 @@ void main() {
           ),
         );
 
-        expect(
-          find.byWidgetPredicate(
-            (widget) =>
-                widget is flutter_html.Html &&
-                widget.style['h6']!.generateTextStyle() ==
-                    flutter_html.Style.fromTextStyle(
-                      theme.textTheme.titleLarge!,
-                    ).generateTextStyle(),
-          ),
-          findsOneWidget,
-        );
+        final expectedStyle = flutter_html.Style.fromTextStyle(
+          theme.textTheme.titleLarge!.copyWith(letterSpacing: 0),
+        ).generateTextStyle();
+
+        final widget =
+            tester.widget(find.byType(flutter_html.Html)) as flutter_html.Html;
+        final style = widget.style['h6']!.generateTextStyle();
+
+        expect(style, expectedStyle);
       });
     });
   });

diff --git a/...packages/news_blocks_ui/test/src/post_medium/post_medium_description_layout.png b/...packages/news_blocks_ui/test/src/post_medium/post_medium_description_layout.png
diff --git a/...le/packages/news_blocks_ui/test/src/post_medium/post_medium_overlaid_layout.png b/...le/packages/news_blocks_ui/test/src/post_medium/post_medium_overlaid_layout.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/post_medium/post_medium_test.dart b/flutter_news_example/packages/news_blocks_ui/test/src/post_medium/post_medium_test.dart
@@ -5,11 +5,17 @@ import 'package:flutter_test/flutter_test.dart';
 import 'package:mocktail_image_network/mocktail_image_network.dart';
 import 'package:news_blocks/news_blocks.dart';
 import 'package:news_blocks_ui/news_blocks_ui.dart';
+import 'package:sqflite_common_ffi/sqflite_ffi.dart';
 
 import '../../helpers/helpers.dart';
 
 void main() {
   setUpAll(() {
+    // Initialize FFI
+    sqfliteFfiInit();
+    // Change the default factory
+    databaseFactory = databaseFactoryFfi;
+
     setUpTolerantComparator();
     setUpMockPathProvider();
   });

diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/post_small_test.dart b/flutter_news_example/packages/news_blocks_ui/test/src/post_small_test.dart
@@ -5,12 +5,18 @@ import 'package:flutter_test/flutter_test.dart';
 import 'package:mocktail_image_network/mocktail_image_network.dart';
 import 'package:news_blocks/news_blocks.dart';
 import 'package:news_blocks_ui/news_blocks_ui.dart';
+import 'package:sqflite_common_ffi/sqflite_ffi.dart';
 
 import '../helpers/helpers.dart';
 
 void main() {
   group('PostSmall', () {
     setUpAll(() {
+      // Initialize FFI
+      sqfliteFfiInit();
+      // Change the default factory
+      databaseFactory = databaseFactoryFfi;
+
       setUpTolerantComparator();
       setUpMockPathProvider();
     });

diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/post_small_with_image.png b/flutter_news_example/packages/news_blocks_ui/test/src/post_small_with_image.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/post_small_without_image.png b/flutter_news_example/packages/news_blocks_ui/test/src/post_small_without_image.png
diff --git a/...er_news_example/packages/news_blocks_ui/test/src/section_header_with_action.png b/...er_news_example/packages/news_blocks_ui/test/src/section_header_with_action.png
diff --git a/...news_example/packages/news_blocks_ui/test/src/section_header_without_action.png b/...news_example/packages/news_blocks_ui/test/src/section_header_without_action.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/spacing_extra_large.png b/flutter_news_example/packages/news_blocks_ui/test/src/spacing_extra_large.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/spacing_extra_small.png b/flutter_news_example/packages/news_blocks_ui/test/src/spacing_extra_small.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/spacing_large.png b/flutter_news_example/packages/news_blocks_ui/test/src/spacing_large.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/spacing_medium.png b/flutter_news_example/packages/news_blocks_ui/test/src/spacing_medium.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/spacing_small.png b/flutter_news_example/packages/news_blocks_ui/test/src/spacing_small.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/spacing_very_large.png b/flutter_news_example/packages/news_blocks_ui/test/src/spacing_very_large.png
diff --git a/...s_example/packages/news_blocks_ui/test/src/text_caption_light_color_default.png b/...s_example/packages/news_blocks_ui/test/src/text_caption_light_color_default.png
diff --git a/..._example/packages/news_blocks_ui/test/src/text_caption_light_color_provided.png b/..._example/packages/news_blocks_ui/test/src/text_caption_light_color_provided.png
diff --git a/..._example/packages/news_blocks_ui/test/src/text_caption_normal_color_default.png b/..._example/packages/news_blocks_ui/test/src/text_caption_normal_color_default.png
diff --git a/...example/packages/news_blocks_ui/test/src/text_caption_normal_color_provided.png b/...example/packages/news_blocks_ui/test/src/text_caption_normal_color_provided.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/text_headline.png b/flutter_news_example/packages/news_blocks_ui/test/src/text_headline.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/text_lead_paragraph.png b/flutter_news_example/packages/news_blocks_ui/test/src/text_lead_paragraph.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/text_paragraph.png b/flutter_news_example/packages/news_blocks_ui/test/src/text_paragraph.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/trending_story.png b/flutter_news_example/packages/news_blocks_ui/test/src/trending_story.png
diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/trending_story_test.dart b/flutter_news_example/packages/news_blocks_ui/test/src/trending_story_test.dart
@@ -4,12 +4,18 @@ import 'package:flutter_test/flutter_test.dart';
 import 'package:mocktail_image_network/mocktail_image_network.dart';
 import 'package:news_blocks/news_blocks.dart';
 import 'package:news_blocks_ui/news_blocks_ui.dart';
+import 'package:sqflite_common_ffi/sqflite_ffi.dart';
 
 import '../helpers/helpers.dart';
 
 void main() {
   group('TrendingStory', () {
     setUpAll(() {
+      // Initialize FFI
+      sqfliteFfiInit();
+      // Change the default factory
+      databaseFactory = databaseFactoryFfi;
+
       setUpTolerantComparator();
       setUpMockPathProvider();
     });

diff --git a/flutter_news_example/packages/news_blocks_ui/test/src/widgets/post_footer.png b/flutter_news_example/packages/news_blocks_ui/test/src/widgets/post_footer.png
diff --git a/...ws_example/packages/news_blocks_ui/test/src/widgets/post_footer_with_author.png b/...ws_example/packages/news_blocks_ui/test/src/widgets/post_footer_with_author.png
diff --git a/...es/news_blocks_ui/test/src/widgets/post_footer_with_author_and_published_at.png b/...es/news_blocks_ui/test/src/widgets/post_footer_with_author_and_published_at.png
diff --git a/...mple/packages/news_blocks_ui/test/src/widgets/post_footer_with_published_at.png b/...mple/packages/news_blocks_ui/test/src/widgets/post_footer_with_published_at.png