Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop beta branch CI, update main branch CI to check for flutter/games #4

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Drop beta branch CI, update main branch CI to check for flutter/games #4

merged 2 commits into from
Nov 8, 2023

Conversation

domesticmouse
Copy link
Contributor

Hopefully fix CI. crosses fingers

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse
Copy link
Contributor Author

Hey @filiph did I mention that debugging CI is always fun?

filiph
filiph approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@filiph filiph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And you were right, this is pure merriment.

@domesticmouse domesticmouse merged commit 348685a into main Nov 8, 2023
7 checks passed
@domesticmouse domesticmouse deleted the ci-fix branch November 8, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiph filiph filiph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domesticmouse @filiph