Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template version to AndroidManifest.xml and Info.plist #17

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

filiph
Copy link
Contributor

@filiph filiph commented Dec 20, 2023

For tracking purposes, we're adding a key-value pair to each game template. This can be used by the AdMob plugin to recognize that this is a Flutter game built on top of the template.

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is template version all you want to track? Also, you may want to add a comment justifying to the template user why they should leave it in their published game.

@filiph
Copy link
Contributor Author

filiph commented Jan 3, 2024

I've changed the wording.

@domesticmouse domesticmouse merged commit 838a7dd into flutter:main Jan 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants