Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate WidgetsBindingObserver to AppLifecycleListener #11

Merged

Conversation

S-ecki
Copy link
Contributor

@S-ecki S-ecki commented Nov 26, 2023

As noted in a todo comment from filiph, listening to the lifecycle events should be migrated to the new AppLifecycleListener according to this blog post.

This has been done for all 3 templates and all 2 samples.

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link

google-cla bot commented Nov 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@domesticmouse
Copy link
Contributor

PTAL @filiph

@domesticmouse domesticmouse merged commit 1f2fceb into flutter:main Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants