Enforce strict casts rule

The `strict-casts` analyzer option is enabled on `flutter/website` sample code and possibly makes sense to enable here as well. It is the modern version of the old “implicit-casts” strong mode option. https://dart.dev/tools/analysis#enabling-additional-type-checks
flutter · Jan 3, 2024 · 2300131 · 2300131
1 parent 1f2fceb
commit 2300131
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 3 deletions.
diff --git a/samples/ads/analysis_options.yaml b/samples/ads/analysis_options.yaml
@@ -1,5 +1,9 @@
 include: package:flutter_lints/flutter.yaml
 
+analyzer:
+  language:
+    strict-casts: true
+
 linter:
   rules:
     # Remove or force lint rules by adding lines like the following.

diff --git a/samples/multiplayer/analysis_options.yaml b/samples/multiplayer/analysis_options.yaml
@@ -1,5 +1,9 @@
 include: package:flutter_lints/flutter.yaml
 
+analyzer:
+  language:
+    strict-casts: true
+
 linter:
   rules:
     # Remove or force lint rules by adding lines like the following.

diff --git a/samples/multiplayer/lib/game_internals/playing_card.dart b/samples/multiplayer/lib/game_internals/playing_card.dart
@@ -18,7 +18,7 @@ class PlayingCard {
     return PlayingCard(
       CardSuit.values
           .singleWhere((e) => e.internalRepresentation == json['suit']),
-      json['value'],
+      json['value'] as int,
     );
   }
 

diff --git a/samples/multiplayer/lib/multiplayer/firestore_controller.dart b/samples/multiplayer/lib/multiplayer/firestore_controller.dart
@@ -72,7 +72,7 @@ class FirestoreController {
     DocumentSnapshot<Map<String, dynamic>> snapshot,
     SnapshotOptions? options,
   ) {
-    final data = snapshot.data()?['cards'];
+    final data = snapshot.data()?['cards'] as List?;
 
     if (data == null) {
       _log.info('No data found on Firestore, returning empty list');

diff --git a/templates/basic/analysis_options.yaml b/templates/basic/analysis_options.yaml
@@ -1,5 +1,9 @@
 include: package:flutter_lints/flutter.yaml
 
+analyzer:
+  language:
+    strict-casts: true
+
 linter:
   rules:
     # Remove or force lint rules by adding lines like the following.

diff --git a/templates/card/analysis_options.yaml b/templates/card/analysis_options.yaml
@@ -1,5 +1,9 @@
 include: package:flutter_lints/flutter.yaml
 
+analyzer:
+  language:
+    strict-casts: true
+
 linter:
   rules:
     # Remove or force lint rules by adding lines like the following.

diff --git a/templates/card/lib/game_internals/playing_card.dart b/templates/card/lib/game_internals/playing_card.dart
@@ -18,7 +18,7 @@ class PlayingCard {
     return PlayingCard(
       CardSuit.values
           .singleWhere((e) => e.internalRepresentation == json['suit']),
-      json['value'],
+      json['value'] as int,
     );
   }
 

diff --git a/templates/endless_runner/analysis_options.yaml b/templates/endless_runner/analysis_options.yaml
@@ -1 +1,5 @@
 include: package:flutter_lints/flutter.yaml
+
+analyzer:
+  language:
+    strict-casts: true