Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Fixed ui bugs #931

Merged
merged 6 commits into from
Apr 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/pages/backdrop.dart
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,14 @@ class _BackdropState extends State<Backdrop> with TickerProviderStateMixin {
),
),
],
_SettingsIcon(
animationController: _iconController,
toggleSettings: _toggleSettings,
isSettingsOpenNotifier: _isSettingsOpenNotifier,
Positioned(
top: 12,
right: 0,
child: _SettingsIcon(
animationController: _iconController,
toggleSettings: _toggleSettings,
isSettingsOpenNotifier: _isSettingsOpenNotifier,
),
),
],
),
Expand Down
7 changes: 3 additions & 4 deletions lib/studies/crane/backdrop.dart
Original file line number Diff line number Diff line change
Expand Up @@ -356,13 +356,12 @@ class _CraneAppBarState extends State<CraneAppBar> {
textScaleFactor: textScaleFactor,
),
controller: widget.tabController,
labelPadding: isDesktop
? const EdgeInsets.symmetric(horizontal: 32)
: EdgeInsets.zero,
isScrollable: isDesktop,
labelPadding: const EdgeInsets.symmetric(horizontal: 32),
isScrollable: true,
// left-align tabs on desktop
labelStyle: Theme.of(context).textTheme.labelLarge,
labelColor: cranePrimaryWhite,
physics: const BouncingScrollPhysics(),
unselectedLabelColor: cranePrimaryWhite.withOpacity(.6),
onTap: (index) => widget.tabController.animateTo(
index,
Expand Down
2 changes: 1 addition & 1 deletion lib/studies/shrine/supplemental/asymmetric_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class MobileAsymmetricView extends StatelessWidget {
16,
_bottomPadding,
),
physics: const AlwaysScrollableScrollPhysics(),
physics: const BouncingScrollPhysics(),
children: _buildColumns(context, constraints),
);
},
Expand Down