Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent DevTools from automatically resuming on connection when there is a breakpoint #8991

Merged
merged 4 commits into from
Mar 6, 2025
Merged

Prevent DevTools from automatically resuming on connection when there is a breakpoint #8991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7e6e25
Conditionally resume isolate on initialization
elliette Mar 5, 2025
22ebef5
Update isolate ref id
elliette Mar 5, 2025
5f27b1b
Update release notes
elliette Mar 6, 2025
2aadb85
Merge branch 'master' into issue-8812
elliette Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,17 @@ class BreakpointManager with DisposerMixin {
);
}

// Resume the isolate now that the breakpoints have been set:
await serviceConnection.serviceManager.isolateManager.resumeIsolate(
isolateRef,
);
// Maybe resume the isolate now that the breakpoints have been set:
final isolate = await _service.getIsolate(_isolateRefId);
final pauseEventKind = isolate.pauseEvent?.kind;
if ([
EventKind.kPauseStart,
EventKind.kPausePostRequest,
].contains(pauseEventKind)) {
await serviceConnection.serviceManager.isolateManager.resumeIsolate(
isolateRef,
);
}
}

void clearCache({required bool isServiceShutdown}) {
Expand Down
17 changes: 17 additions & 0 deletions packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,25 @@ To learn more about DevTools, check out the

## General updates

* Fixed various memory leaks and lifecycle issues. -
[#8901](https://github.com/flutter/devtools/pull/8901),
[#8902](https://github.com/flutter/devtools/pull/8902),
[#8907](https://github.com/flutter/devtools/pull/8907),
[#8917](https://github.com/flutter/devtools/pull/8917),
[#8932](https://github.com/flutter/devtools/pull/8932),
[#8933](https://github.com/flutter/devtools/pull/8933),
[#8934](https://github.com/flutter/devtools/pull/8934),
[#8935](https://github.com/flutter/devtools/pull/8935),
[#8937](https://github.com/flutter/devtools/pull/8937),
[#8953](https://github.com/flutter/devtools/pull/8953),
[#8969](https://github.com/flutter/devtools/pull/8969),
[#8970](https://github.com/flutter/devtools/pull/8970),
[#8975](https://github.com/flutter/devtools/pull/8975)
* Fix a bug with the review history on disconnect experience. -
[#8985](https://github.com/flutter/devtools/pull/8985)
* Fixed bug where DevTools would automatically resume instead of
pausing on breakpoint on connection. -
[#8991](https://github.com/flutter/devtools/pull/8991)

## Inspector updates

Expand Down