[Property Editor] Add analytics to the Property Editor #8840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ga.impression( | ||
| gaId, | ||
| gac.PropertyEditorSidebar.widgetPropertiesUpdate.name, | ||
| // TODO(): Add metrics for widget name. |
There was a problem hiding this comment.
We have to be careful with the number of metrics we add because GA4 has a limit. Maybe we need a generic field where we can pass an extra bit of data that we can re-use for several analytics events.
There was a problem hiding this comment.
Updated the TODO to specify postfixing the widget name to this event so that we aren't adding more metrics
kenzieschmoll
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8774
Work towards #1948
Adds analytic events to the Property Editor.