Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License update - Batch 18 #8696

Merged
merged 2 commits into from
Jan 14, 2025
Merged

License update - Batch 18 #8696

merged 2 commits into from
Jan 14, 2025

Conversation

mossmana
Copy link
Contributor

Updates the license headers for:

  1. packages/devtools_app/lib/src/screens/inspector_v2/inspector_controller.dart
  2. packages/devtools_app/lib/src/screens/inspector_v2/inspector_data_models.dart
  3. packages/devtools_app/lib/src/screens/inspector_v2/inspector_screen_body.dart
  4. packages/devtools_app/lib/src/screens/inspector_v2/inspector_tree_controller.dart
  5. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/box/box.dart
  6. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/flex/flex.dart
  7. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/flex/utils.dart
  8. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/arrow.dart
  9. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/dimension.dart
  10. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/free_space.dart
  11. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/layout_explorer_widget.dart
  12. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/overflow_indicator_painter.dart
  13. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/theme.dart
  14. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/utils.dart
  15. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/widget_constraints.dart
  16. packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/widgets_theme.dart
  17. packages/devtools_app/lib/src/screens/inspector_v2/widget_details.dart
  18. packages/devtools_app/lib/src/screens/inspector_v2/widget_properties/properties_view.dart
  19. packages/devtools_app/test/screens/inspector_v2/diagnostics_test.dart
  20. packages/devtools_app/test/screens/inspector_v2/inspector_error_navigator_test.dart
  21. packages/devtools_app/test/screens/inspector_v2/inspector_integration_test.dart
  22. packages/devtools_app/test/screens/inspector_v2/inspector_screen_test.dart
  23. packages/devtools_app/test/screens/inspector_v2/inspector_tree_test.dart
  24. packages/devtools_app/test/screens/inspector_v2/layout_explorer/flex/arrow_test.dart
  25. packages/devtools_app/test/screens/inspector_v2/layout_explorer/flex/flex_test.dart
  26. packages/devtools_app/test/screens/inspector_v2/layout_explorer/inspector_data_models_test.dart
  27. packages/devtools_app/test/screens/inspector_v2/layout_explorer/layout_explorer_serialization_delegate.dart
  28. packages/devtools_app/test/screens/inspector_v2/layout_explorer/layout_explorer_test_utils.dart
  29. packages/devtools_app/test/screens/inspector_v2/layout_explorer/widget_theme_test.dart
  30. packages/devtools_app/test/screens/inspector_v2/utils/inspector_tree.dart

#8216

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

@mossmana mossmana marked this pull request as ready for review January 13, 2025 18:31
@mossmana mossmana requested a review from a team as a code owner January 13, 2025 18:31
@mossmana mossmana requested review from elliette and removed request for a team January 13, 2025 18:31
kenzieschmoll
kenzieschmoll reviewed Jan 13, 2025
View reviewed changes
packages/devtools_app/test/screens/inspector_v2/diagnostics_test.dart Outdated
Comment on lines 1 to 6
// Copyright 2025 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
// Copyright 2022 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be found
// in the LICENSE file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate header. Would be good to understand why the few files that didn't get updated properly are different than the rest that were successfully updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be a difference in whitespace, but I'll confirm. I likely have to adjust the config file for some edge cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"found" needs to be on the next line for the exact matching to work properly

kenzieschmoll
kenzieschmoll approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one commennt

@mossmana mossmana merged commit e475ad1 into flutter:master Jan 14, 2025
24 checks passed
@mossmana mossmana deleted the 8216-batch18 branch January 14, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@elliette elliette Awaiting requested review from elliette elliette is a code owner automatically assigned from flutter/devtools-reviewers

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossmana @kenzieschmoll