Enable prefer_final_in_for_each lint for consistency (#7866)

packages/analysis_options.yaml

@@ -102,6 +102,7 @@ linter:
     - prefer_contains
     # - prefer_expression_function_bodies # conflicts with https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#consider-using--for-short-functions-and-methods
     - prefer_final_fields
+    - prefer_final_in_for_each
     - prefer_final_locals
     - prefer_foreach
     # - prefer_function_declarations_over_variables # not yet tested

packages/devtools_app/lib/src/framework/app_bar.dart

@@ -65,15 +65,15 @@ class DevToolsAppBar extends StatelessWidget {
         isScrollable: true,
         labelPadding: EdgeInsets.zero,
         tabs: [
-          for (var screen in visibleScreens)
+          for (final screen in visibleScreens)
             Padding(
               padding: const EdgeInsets.symmetric(horizontal: tabBarSpacing),
               child: screen.buildTab(context),
             ),
           // We need to include a widget in the tab bar for the overflow screens
           // because the [_tabController] expects a length equal to the total
           // number of screens, hidden or not.
-          for (var _ in overflowScreens) const SizedBox.shrink(),
+          for (final _ in overflowScreens) const SizedBox.shrink(),
         ],
       );
 

packages/devtools_app/lib/src/framework/scaffold.dart

@@ -276,7 +276,7 @@ class DevToolsScaffoldState extends State<DevToolsScaffold>
   Widget build(BuildContext context) {
     // Build the screens for each tab and wrap them in the appropriate styling.
     final tabBodies = [
-      for (var screen in widget.screens)
+      for (final screen in widget.screens)
         Align(
           alignment: Alignment.topLeft,
           child: FocusScope(

packages/devtools_app/lib/src/screens/app_size/app_size_controller.dart

@@ -687,7 +687,7 @@ class AppSizeController {
     int totalByteSize = 0;
 
     // Given a child, build its subtree.
-    for (Map<String, dynamic> child in rawChildren) {
+    for (final Map<String, dynamic> child in rawChildren) {
       final childTreemapNode = showDiff
           ? generateDiffTree(child, diffTreeType!)
           : generateTree(child);
@@ -721,7 +721,7 @@ class AppSizeController {
     }
     final childrenMap = <String, TreemapNode>{};
 
-    for (TreemapNode child in children) {
+    for (final child in children) {
       childrenMap[child.name] = child;
     }
 

packages/devtools_app/lib/src/screens/app_size/code_size_attribution.dart

@@ -336,7 +336,7 @@ class DominatorTreeNode extends TreeNode<DominatorTreeNode> {
 
   factory DominatorTreeNode.from(CallGraphNode cgNode) {
     final domNode = DominatorTreeNode._(cgNode);
-    for (var dominated in cgNode.dominated) {
+    for (final dominated in cgNode.dominated) {
       domNode.addChild(DominatorTreeNode.from(dominated));
     }
     return domNode;

packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart

@@ -298,10 +298,10 @@ class BreakpointManager with DisposerMixin {
 
     final positions = <SourcePosition>[];
 
-    for (SourceReportRange range in report.ranges!) {
+    for (final range in report.ranges!) {
       final possibleBreakpoints = range.possibleBreakpoints;
       if (possibleBreakpoints != null) {
-        for (int tokenPos in possibleBreakpoints) {
+        for (final tokenPos in possibleBreakpoints) {
           positions.add(SourcePosition.calculatePosition(script, tokenPos));
         }
       }
@@ -361,7 +361,7 @@ class BreakpointManager with DisposerMixin {
       case EventKind.kBreakpointResolved:
         final breakpoint = event.breakpoint!;
         _breakpoints.value = [
-          for (var b in _breakpoints.value)
+          for (final b in _breakpoints.value)
             if (b != event.breakpoint) b,
           breakpoint,
         ];
@@ -393,12 +393,12 @@ class BreakpointManager with DisposerMixin {
         final breakpoint = event.breakpoint;
 
         _breakpoints.value = [
-          for (var b in _breakpoints.value)
+          for (final b in _breakpoints.value)
             if (b != breakpoint) b,
         ];
 
         _breakpointsWithLocation.value = [
-          for (var b in _breakpointsWithLocation.value)
+          for (final b in _breakpointsWithLocation.value)
             if (b.breakpoint != breakpoint) b,
         ];
 

packages/devtools_app/lib/src/screens/debugger/controls.dart

@@ -258,7 +258,7 @@ class BreakOnExceptionsControl extends StatelessWidget {
                 },
           isDense: true,
           items: [
-            for (var mode in ExceptionMode.modes)
+            for (final mode in ExceptionMode.modes)
               DropdownMenuItem<ExceptionMode>(
                 value: mode,
                 child: Text(

packages/devtools_app/lib/src/screens/debugger/debugger_model.dart

@@ -263,12 +263,12 @@ class FileNode extends TreeNode<FileNode> {
     // The name of this node is not exposed to users.
     final root = FileNode('<root>');
 
-    for (var script in scripts) {
+    for (final script in scripts) {
       final directoryParts = ScriptRefUtils.splitDirectoryParts(script);
 
       FileNode node = root;
 
-      for (var name in directoryParts) {
+      for (final name in directoryParts) {
         node = node._getCreateChild(name);
       }
 
@@ -294,7 +294,7 @@ class FileNode extends TreeNode<FileNode> {
   void _trimChildrenAsMapEntries() {
     _childrenAsMap.clear();
 
-    for (var child in children) {
+    for (final child in children) {
       child._trimChildrenAsMapEntries();
     }
   }

packages/devtools_app/lib/src/screens/debugger/program_explorer_model.dart

@@ -376,7 +376,7 @@ class VMServiceObjectNode extends TreeNode<VMServiceObjectNode> {
   void _trimChildrenAsMapEntries() {
     _childrenAsMap.clear();
 
-    for (var child in children) {
+    for (final child in children) {
       child._trimChildrenAsMapEntries();
     }
   }

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_controller.dart

@@ -157,7 +157,7 @@ class DeepLinksController extends DisposableController
   @visibleForTesting
   List<LinkData> linkDatasByPath(List<LinkData> linkdatas) {
     final linkDatasByPath = <String, LinkData>{};
-    for (var linkData in linkdatas) {
+    for (final linkData in linkdatas) {
       final previousRecord = linkDatasByPath[linkData.path];
       linkDatasByPath[linkData.path] = LinkData(
         domain: linkData.domain,
@@ -185,7 +185,7 @@ class DeepLinksController extends DisposableController
   @visibleForTesting
   List<LinkData> linkDatasByDomain(List<LinkData> linkdatas) {
     final linkDatasByDomain = <String, LinkData>{};
-    for (var linkData in linkdatas) {
+    for (final linkData in linkdatas) {
       if (linkData.domain.isNullOrEmpty) {
         continue;
       }

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_services.dart

@@ -63,7 +63,7 @@ class DeepLinksServices {
     required String? localFingerprint,
   }) async {
     final domainErrors = <String, List<DomainError>>{
-      for (var domain in domains) domain: <DomainError>[],
+      for (final domain in domains) domain: <DomainError>[],
     };
 
     // The request can take 1000 domains at most, make a few calls in serial with a batch of _domainBatchSize.

packages/devtools_app/lib/src/screens/inspector/inspector_data_models.dart

@@ -68,11 +68,11 @@ List<double> computeRenderSizes({
     // and we can just divide the size evenly
     // but it should be at least as big as [smallestRenderSize]
     final renderSize = math.max(smallestRenderSize, maxSizeAvailable / n);
-    return [for (var _ in sizes) renderSize];
+    return [for (final _ in sizes) renderSize];
   }
 
   List<double> transformToRenderSize(double largestRenderSize) => [
-        for (var s in sizes)
+        for (final s in sizes)
           (s - smallestSize) *
                   (largestRenderSize - smallestRenderSize) /
                   (largestSize - smallestSize) +
@@ -84,7 +84,7 @@ List<double> computeRenderSizes({
   if (useMaxSizeAvailable && sum(renderSizes) < maxSizeAvailable) {
     largestRenderSize = (maxSizeAvailable - n * smallestRenderSize) *
             (largestSize - smallestSize) /
-            sum([for (var s in sizes) s - smallestSize]) +
+            sum([for (final s in sizes) s - smallestSize]) +
         smallestRenderSize;
     renderSizes = transformToRenderSize(largestRenderSize);
   }
@@ -108,7 +108,7 @@ class LayoutProperties {
                   (child) => LayoutProperties(child, copyLevel: copyLevel - 1),
                 )
                 .toList(growable: false) {
-    for (var child in children) {
+    for (final child in children) {
       child.parent = this;
     }
   }
@@ -123,7 +123,7 @@ class LayoutProperties {
     required this.size,
     required this.flexFit,
   }) {
-    for (var child in children) {
+    for (final child in children) {
       child.parent = this;
     }
   }

packages/devtools_app/lib/src/screens/inspector/inspector_tree_controller.dart

@@ -147,13 +147,13 @@ class InspectorTreeController extends DisposableController
   // Method defined to avoid a direct Flutter dependency.
   void setState(VoidCallback fn) {
     fn();
-    for (var client in _clients) {
+    for (final client in _clients) {
       client.onChanged();
     }
   }
 
   void requestFocus() {
-    for (var client in _clients) {
+    for (final client in _clients) {
       client.requestFocus();
     }
   }
@@ -468,7 +468,7 @@ class InspectorTreeController extends DisposableController
   }
 
   void scrollToRect(Rect targetRect) {
-    for (var client in _clients) {
+    for (final client in _clients) {
       client.scrollToRect(targetRect);
     }
   }
@@ -499,7 +499,7 @@ class InspectorTreeController extends DisposableController
   void animateToTargets(List<InspectorTreeNode> targets) {
     Rect? targetRect;
 
-    for (InspectorTreeNode target in targets) {
+    for (final target in targets) {
       final row = getRowForNode(target);
       if (row != null) {
         final rowRect = getBoundingBox(row);
@@ -582,7 +582,7 @@ class InspectorTreeController extends DisposableController
     }
     final inlineProperties = parent.inlineProperties;
 
-    for (RemoteDiagnosticsNode property in inlineProperties) {
+    for (final property in inlineProperties) {
       appendChild(
         treeNode,
         setupInspectorTreeNode(
@@ -596,7 +596,7 @@ class InspectorTreeController extends DisposableController
       );
     }
     if (children != null) {
-      for (RemoteDiagnosticsNode child in children) {
+      for (final child in children) {
         appendChild(
           treeNode,
           setupInspectorTreeNode(
@@ -1133,7 +1133,7 @@ class _RowPainter extends CustomPainter {
 
     final InspectorTreeNode node = row.node;
     final bool showExpandCollapse = node.showExpandCollapse;
-    for (int tick in row.ticks) {
+    for (final int tick in row.ticks) {
       currentX = _controller.getDepthIndent(tick) - inspectorColumnWidth * 0.5;
       // Draw a vertical line for each tick identifying a connection between
       // an ancestor of this node and some other node in the tree.

packages/devtools_app/lib/src/screens/inspector/layout_explorer/box/box.dart

@@ -135,7 +135,7 @@ class BoxLayoutExplorerWidgetState extends LayoutExplorerWidgetState<
     final length = sizes.length;
     double total = 1.0; // This isn't set to zero to avoid divide by zero bugs.
     final fractions = minFractions.toList();
-    for (var size in sizes) {
+    for (final size in sizes) {
       if (size != null) {
         total += math.max(0, size);
       }
@@ -157,7 +157,7 @@ class BoxLayoutExplorerWidgetState extends LayoutExplorerWidgetState<
       }
     }
     final output = <double>[];
-    for (var fraction in fractions) {
+    for (final fraction in fractions) {
       output.add(fraction * availableSize);
     }
     return output;

packages/devtools_app/lib/src/screens/inspector/layout_explorer/flex/flex.dart

@@ -155,7 +155,7 @@ class FlexLayoutExplorerWidgetState extends LayoutExplorerWidgetState<
               : colorScheme.crossAxisColor,
           selectedItemBuilder: (context) {
             return [
-              for (var alignment in alignmentEnumEntries)
+              for (final alignment in alignmentEnumEntries)
                 Row(
                   mainAxisAlignment: MainAxisAlignment.center,
                   children: [
@@ -190,7 +190,7 @@ class FlexLayoutExplorerWidgetState extends LayoutExplorerWidgetState<
             ];
           },
           items: [
-            for (var alignment in alignmentEnumEntries)
+            for (final alignment in alignmentEnumEntries)
               DropdownMenuItem(
                 value: alignment,
                 child: Container(
@@ -510,7 +510,7 @@ class _VisualizeFlexChildrenState extends State<VisualizeFlexChildren> {
           }
 
           final freeSpacesWidgets = [
-            for (var renderProperties in [
+            for (final renderProperties in [
               ...mainAxisSpaces,
               ...crossAxisSpaces,
             ])

packages/devtools_app/lib/src/screens/inspector_v2/inspector_data_models.dart

@@ -68,11 +68,11 @@ List<double> computeRenderSizes({
     // and we can just divide the size evenly
     // but it should be at least as big as [smallestRenderSize]
     final renderSize = math.max(smallestRenderSize, maxSizeAvailable / n);
-    return [for (var _ in sizes) renderSize];
+    return [for (final _ in sizes) renderSize];
   }
 
   List<double> transformToRenderSize(double largestRenderSize) => [
-        for (var s in sizes)
+        for (final s in sizes)
           (s - smallestSize) *
                   (largestRenderSize - smallestRenderSize) /
                   (largestSize - smallestSize) +
@@ -84,7 +84,7 @@ List<double> computeRenderSizes({
   if (useMaxSizeAvailable && sum(renderSizes) < maxSizeAvailable) {
     largestRenderSize = (maxSizeAvailable - n * smallestRenderSize) *
             (largestSize - smallestSize) /
-            sum([for (var s in sizes) s - smallestSize]) +
+            sum([for (final s in sizes) s - smallestSize]) +
         smallestRenderSize;
     renderSizes = transformToRenderSize(largestRenderSize);
   }
@@ -108,7 +108,7 @@ class LayoutProperties {
                   (child) => LayoutProperties(child, copyLevel: copyLevel - 1),
                 )
                 .toList(growable: false) {
-    for (var child in children) {
+    for (final child in children) {
       child.parent = this;
     }
   }
@@ -123,7 +123,7 @@ class LayoutProperties {
     required this.size,
     required this.flexFit,
   }) {
-    for (var child in children) {
+    for (final child in children) {
       child.parent = this;
     }
   }