-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Flutter 3.27 #16
Conversation
@mit-mit who do I hassle to find out why my PRs don't trigger CI? |
Since the action isn't triggering at all, it seems like there might need to be a change to the repo settings. @Piinks are you able to look at the settings w.r.t. actions on PRs for this repo? |
Taking a look! |
I think it was because this repo was not set up to run workflows on pull requests from forks. I have enabled his now, rebasing may trigger the checks now. Enabling that added some more options, so let me know if CI still is not wokring. |
I checked against some of the other flutter repos, but they appear to be configured differently. |
A repo similar to this one might be https://github.com/flutter/samples. It is running a similar action here https://github.com/flutter/samples/blob/main/.github/workflows/main.yml. |
Ah thank you! I checked that as well, it is also different. I wonder if it is because those are all public repos and this one is private. I think the first setting I updated here should work now since this is coming from a fork. :) |
Thanks, CI appears to run now on a fresh PR: #17 |
I noticed CI was triggering for your PRs before I created this one. So it is something specific to my account... |
Oh interesting. Let me check roles/collaborators/teams configured for this repo. |
Actually, it's triggering now. All good =) |
@csells do you want to publish an updated version of this package to pub.dev? |
Flutter 3.27 introduces some new deprecations, which need fixes...
WIP: This does not compile under Flutter 3.24.x
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.