Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Flutter 3.27 #16

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented Dec 6, 2024

Flutter 3.27 introduces some new deprecations, which need fixes...

WIP: This does not compile under Flutter 3.24.x

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@domesticmouse domesticmouse requested a review from csells December 6, 2024 23:57
@domesticmouse domesticmouse changed the title Fix for Flutter 3.27 beta Fixes for Flutter 3.27 beta Dec 6, 2024
@domesticmouse
Copy link
Contributor Author

@mit-mit who do I hassle to find out why my PRs don't trigger CI?

@domesticmouse domesticmouse marked this pull request as draft December 7, 2024 00:07
@mit-mit
Copy link
Member

mit-mit commented Dec 9, 2024

@mit-mit who do I hassle to find out why my PRs don't trigger CI?

Yeah, I'm puzzled too. Not sure what's going on. I don't have admin in this org, so I can't see the settings. Maybe @zanderso can help?

@zanderso
Copy link
Member

zanderso commented Dec 9, 2024

@mit-mit who do I hassle to find out why my PRs don't trigger CI?

Yeah, I'm puzzled too. Not sure what's going on. I don't have admin in this org, so I can't see the settings. Maybe @zanderso can help?

Since the action isn't triggering at all, it seems like there might need to be a change to the repo settings. @Piinks are you able to look at the settings w.r.t. actions on PRs for this repo?

@Piinks
Copy link

Piinks commented Dec 9, 2024

Taking a look!

@Piinks
Copy link

Piinks commented Dec 9, 2024

I think it was because this repo was not set up to run workflows on pull requests from forks. I have enabled his now, rebasing may trigger the checks now.

Screenshot 2024-12-09 at 10 39 09 AM

Enabling that added some more options, so let me know if CI still is not wokring.
I did not check this since I am not sure what @csells has set up.

Screenshot 2024-12-09 at 10 39 39 AM

@Piinks
Copy link

Piinks commented Dec 9, 2024

I checked against some of the other flutter repos, but they appear to be configured differently.

@zanderso
Copy link
Member

zanderso commented Dec 9, 2024

I checked against some of the other flutter repos, but they appear to be configured differently.

A repo similar to this one might be https://github.com/flutter/samples. It is running a similar action here https://github.com/flutter/samples/blob/main/.github/workflows/main.yml.

@Piinks
Copy link

Piinks commented Dec 9, 2024

Ah thank you! I checked that as well, it is also different. I wonder if it is because those are all public repos and this one is private.

I think the first setting I updated here should work now since this is coming from a fork. :)

@mit-mit
Copy link
Member

mit-mit commented Dec 9, 2024

Thanks, CI appears to run now on a fresh PR: #17

@domesticmouse
Copy link
Contributor Author

Thanks, CI appears to run now on a fresh PR: #17

I noticed CI was triggering for your PRs before I created this one. So it is something specific to my account...

@Piinks
Copy link

Piinks commented Dec 9, 2024

Oh interesting. Let me check roles/collaborators/teams configured for this repo.

@domesticmouse
Copy link
Contributor Author

Oh interesting. Let me check roles/collaborators/teams configured for this repo.

Actually, it's triggering now. All good =)

@domesticmouse domesticmouse changed the title Fixes for Flutter 3.27 beta Fixes for Flutter 3.27 Dec 10, 2024
@domesticmouse domesticmouse marked this pull request as ready for review December 11, 2024 18:37
@domesticmouse domesticmouse merged commit e3d6203 into flutter:main Dec 11, 2024
3 checks passed
@domesticmouse domesticmouse deleted the flutter-3.27-beta branch December 11, 2024 19:13
@domesticmouse
Copy link
Contributor Author

@csells do you want to publish an updated version of this package to pub.dev?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants