Skip to content

Commit

Permalink
chore: review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Remon committed Dec 18, 2024
1 parent ddab50b commit 07b1d73
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion example/android/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pluginManagement {

plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "8.6.1" apply false
id "com.android.application" version "8.7.3" apply false
id "org.jetbrains.kotlin.android" version "1.8.10" apply false
}

Expand Down
15 changes: 8 additions & 7 deletions packages/stripe/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,18 @@ This plugin requires several changes to be able to work on Android devices. Plea
-dontwarn com.stripe.android.pushProvisioning.PushProvisioningActivityStarter
-dontwarn com.stripe.android.pushProvisioning.PushProvisioningEphemeralKeyProvider
```
8. Rebuild the app, as the above changes don't update with hot reload
8. Add the following line to your `gradle.properties` file: [example](https://github.com/flutter-stripe/flutter_stripe/blob/master/example/android/gradle.properties)
```properties
android.enableR8.fullMode=false
```
This will prevent crashes with the Stripe SDK on Android (see [issue](https://github.com/flutter-stripe/flutter_stripe/issues/1909)).

9. Rebuild the app, as the above changes don't update with hot reload

These changes are needed because the Android Stripe SDK requires the use of the AppCompat theme for their UI components and the Support Fragment Manager for the Payment Sheets

If you are having troubles to make this package to work on Android, join [this discussion](https://github.com/flutter-stripe/flutter_stripe/discussions/538) to get some support.

##### Issue with latest Android plugin

We are aware of an issue with `com.android.application` plugin version 8.0.0 and above. Do not upgrade to this version as it can crash the payment sheet in release builds. See [issue](https://github.com/flutter-stripe/flutter_stripe/issues/1909) to follow the progress.

#### iOS

Compatible with apps targeting iOS 13 or above.
Expand All @@ -85,8 +87,7 @@ For card scanning add the following to your Info.plist:
```xml
<key>NSCameraUsageDescription</key>
<string>Scan your card to add it automatically</string>
<key>NSCameraUsageDescription
&lt;string&gt;To scan cards&lt;/string&gt;</key>
<key>NSCameraUsageDescription</key>
<string>To scan cards</string>
```

Expand Down

0 comments on commit 07b1d73

Please sign in to comment.