Add more test coverage

[martijn00]

Connection with issue(s)

Close #???

Connected to #???

Solution description

Screenshots or Videos

To Do

• Read contributing guide
• Check the original issue to confirm it is fully satisfied
• Add solution description to help guide reviewers
• Add unit test to verify new or fixed behaviour
• If apply, add documentation to code properties and package readme

[deandreamatias]

Make sense that core validators/helpers use BaseValidator if not use translatedErrorText?

String get translatedErrorText => '';
  // coverage:ignore-end

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (995b030) to head (1d15895).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   95.11%   99.20%   +4.09%     
==========================================
  Files          94       95       +1     
  Lines        1024     1011      -13     
==========================================
+ Hits          974     1003      +29     
+ Misses         50        8      -42     

Flag	Coverage Δ
unittests	99.20% <100.00%> (+4.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[martijn00]

Yes it still makes sense because they use the validate methods and other users can extend them.

[deandreamatias]

Yes it still makes sense because they use the validate methods and other users can extend them.

Yeah, but maybe can create a CoreValidator without translatedErrorText and BaseValidator extends this? I don't if this could be work.

Ignore a thing that won't be used, I don't see like a good practice

[martijn00]

@deandreamatias I've implemented this now. Can you check and merge?