-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get data from API without SQLite #40
Open
JrtPec
wants to merge
24
commits into
flukso:master
Choose a base branch
from
JrtPec:direct_api_client
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* typo in tz_localize * tmpo delete query * reset method * version bump * Split `SQL_TMPO_LAST` into `SQL_TMPO_LAST` (which now doesn't include data) and `SQL_TMPO_LAST_DATA` (which does include data). Sync uses the one without data to determine from where to start. * pd.tslib.Timestamp will be deprecated, use pd.Timestamp instead * `ix` is deprecated, changed to `loc` * upgrade of notebook * version bump * also update docstrings for Timestamp depreciation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing data in a local SQLite DB isn't always convenient, for instance when using TMPO in a microservice where you have no permanent storage. I added functionality to download and parse TMPO data directly from the API without storing it in between. It should all be backwards compatible.
__init__.py
.Session
class does not exists anymore, there are two new classes:APISession
andSQLiteSession
.APISession
contains all API calls, block processing, and pandas parsing. It grabs data directly from the API without intermediate storage.SQLiteSession
subclassesAPISession
and has the existing functionality that involves the local SQLite DB.SQLiteSession
is completely backwards compatible with the oldSession
. So you can import it usingfrom tmpo import Session
andfrom tmpo import SQLiteSession
. Same thing.I will start using the code next week on EnergyID, so any bugs should be gone by then.
I have only tested this on Python3, I don't know (and don't care) if this works on PY2.