Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null check cards on layout init #1484

Merged

Conversation

pedrolamas
Copy link
Member

We have had a few reports from users that Fluidd stops working after editing the dashboard layout.

It seems that somehow the layout data is getting incorrectly recorded in the database with null values for some cards.

image

Though I don't yet know the reason for this happening, the proposed fix here is to filter these null values out before we attempt to load the layout.

Fixes #1473

@pedrolamas pedrolamas added the GH - Bug Something isn't working label Aug 15, 2024
@pedrolamas pedrolamas added this to the 1.30.4 milestone Aug 15, 2024
@pedrolamas pedrolamas requested a review from matmen August 15, 2024 13:56
matmen
matmen previously approved these changes Aug 15, 2024
@pedrolamas
Copy link
Member Author

Initial fix didn't solve the problem as the null value filtering needs to be done a bit earlier, so I moved the code above.

@pedrolamas pedrolamas requested a review from matmen August 15, 2024 14:23
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't have access to a machine running fluidd for the next couple of days, so I can't test it functionality wise, but the code LGTM

@pedrolamas pedrolamas merged commit 3f1d22e into fluidd-core:develop Aug 16, 2024
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/layout-card-null-check branch August 16, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web interface not visible
2 participants