feat: adds new Screws Tilt Adjust helper dialog #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas
force-pushed
the
pedrolamas/screws-tilt-adjust
branch
from
3dc1093
to
276f7cd
Compare
|
The Klipper docs state that the bed screws are well adjusted below 6 minutes, so maybe we want to mark them as good then? Something like this should probably suffice: Otherwise LGTM! |
|
Ohh, I wasn't aware of the 6 min recommended limit! Please either change my branch directly or send as a PR targeting my fork and I'll merge it there so we have a single PR here. |
Signed-off-by: Mathis Mensing <[email protected]>
Screws Tilt Adjust helper dialog: mark sub-6-minute adjustments as succeeded
matmen
previously approved these changes
Oct 31, 2023
|
Tested locally, LGTM. Nice work! |
Signed-off-by: Pedro Lamas <[email protected]>
matmen
previously approved these changes
Oct 31, 2023
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog will show when
SCREWS_TILT_CALCULATEfinishes, showing the results of the operation, including how much to turn each screw and to what side (indicated by the icon)Resolves #1184