-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limits the length of the grafana dashboard uid to 40 to prevent grafa… #509
Conversation
Isn't the output of |
It is fixed to 64 chars and so too long for grafana |
hi, can we remove this imp. , I was using old Grafana where if I set uid null not generating unique uid. After upgrading Grafana if we pass null it is working. |
Would be great to get this fix in or as an alternative we simply do not define the uid in the dashboard. Both solutions work, tested in my own setup. |
@stevehipwell done |
@mheers could you rebase this PR? |
@stevehipwell rebased and cleaned history |
@mheers the dco is failing. Maybe fix that to not delay the release of this fix |
Signed-off-by: Marcel Heers <[email protected]>
@marcofranssen fixed. thanks |
@mheers you need to update the version and release notes annotations in Chart.yaml so the workflows will pass. |
Signed-off-by: Marcel Heers <[email protected]>
@stevehipwell updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…na import error
When trying to import the dashboard json the grafana container throws
logger=provisioning.dashboard type=file name=file t=2024-05-23T06:54:30.144967684Z level=error msg="failed to save dashboard" file=/tmp/dashboards/fluentbit-fluent-bit-fluent-bit.json error="uid too long, max 40 characters"
With this fix the length of the uid is trunctated to 40 chars.