Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement internalTrafficPolicy for daemonsets #461

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

Joerit
Copy link
Contributor

@Joerit Joerit commented Feb 21, 2024

Hi 👋

we're using fluentbit as a logstash dropin (i.e. tcp input, output to ES)

deploying as a daemonset with a service causes applications to just push to a random pod running on a random node

internalTrafficPolicy makes the service route to the instance running on the local node (so avoids cross-node traffic)

this change works for my usecase.

Greetings,
Joeri

Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Joerit. I agree that this is a desirable capability. I've added a couple of suggestions, and to get this merged you'd also need to bump the chart version and update the changelog annotations.

charts/fluent-bit/templates/service.yaml Outdated Show resolved Hide resolved
charts/fluent-bit/values.yaml Outdated Show resolved Hide resolved
@Joerit
Copy link
Contributor Author

Joerit commented Mar 6, 2024

merged latest main in, and bumped the chart version + annotation

@Joerit Joerit requested a review from stevehipwell March 6, 2024 12:58
@stevehipwell
Copy link
Collaborator

@Joerit could you sign the DCO?

@Joerit
Copy link
Contributor Author

Joerit commented Mar 6, 2024

@stevehipwell i have
whatever automated process you use to check this seems to be unhappy i signed off with my actuall full name

Summary Author: Joeri, Committer: Joeri; Expected "Joeri [[email protected]](mailto:[email protected])", but got "Joeri Temmerman [[email protected]](mailto:[email protected])".

@stevehipwell
Copy link
Collaborator

@Joerit did you amend all of your commits to be signed off? My suggestion would be to squash your commits and make sure the resulting commit has the correct sign off.

@Joerit
Copy link
Contributor Author

Joerit commented Mar 8, 2024

@stevehipwell
squashed and forced it up.
that should do it then?

@stevehipwell
Copy link
Collaborator

@Joerit the DCO looks good now, but you're out of date with the main branch. Could you rebase your branch please (personally I'd suggest clicking the drop-down in the UI and choosing a rebase)?

Signed-off-by: Joeri Temmerman <[email protected]>

typo'd DaemonSet

Signed-off-by: Joeri <[email protected]>

Apply suggestions from code review

Co-authored-by: Steve Hipwell <[email protected]>
Signed-off-by: Joeri Temmerman <[email protected]>

bump chart version, annotation

Signed-off-by: Joeri <[email protected]>
@Joerit
Copy link
Contributor Author

Joerit commented Mar 8, 2024

@stevehipwell sorry, rebased.

@stevehipwell
Copy link
Collaborator

@Joerit it looks like the chart tests are failing due to an implementation detail, #466 should fix this and then if you rebase your PR should be able to be merged.

@stevehipwell
Copy link
Collaborator

@Joerit if you can rebase your automation should work correctly.

Signed-off-by: Joeri Temmerman <[email protected]>
charts/fluent-bit/Chart.yaml Outdated Show resolved Hide resolved
Signed-off-by: Joeri Temmerman <[email protected]>
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell stevehipwell merged commit 6d6a17d into fluent:main Mar 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants