Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct fluentd helm tests #441

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

pecastro
Copy link
Contributor

@pecastro pecastro commented Nov 16, 2023

Added a few tweaks to make the current default values a bit more complete from a working out of the box perspective and to enable the existing test to pass.
Related to #440

@pecastro pecastro force-pushed the fluentd-440-pecastro branch 7 times, most recently from 7c8bf6d to 29db732 Compare November 16, 2023 22:46
It will time-out after 5 min if things are really broken in line with
the helm test default.

Signed-off-by: Paulo E. Castro <[email protected]>
@pecastro pecastro force-pushed the fluentd-440-pecastro branch from 29db732 to 4a505ec Compare November 16, 2023 22:50
@pecastro
Copy link
Contributor Author

@dioguerra Please have a look...

Copy link
Collaborator

@dioguerra dioguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me,

Sorry I'm out of the game, so now I would need to do this in my own time

@dioguerra dioguerra merged commit 300f3aa into fluent:main Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants