Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fluentd): conditionally update deprecated API for HPA #363

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

Boojapho
Copy link
Contributor

@Boojapho Boojapho commented May 23, 2023

Closes #345

In Fluentd chart, upgrades HPA to v2 when Kubernetes cluster is not < 1.23

@isimluk
Copy link

isimluk commented Sep 22, 2023

👍 Works for me.

I have tried and tested this fix and it works great for me. Thank You.

@jarnfast
Copy link

Any hopes of getting this fixed anytime soon? 🤞

@javiplx
Copy link

javiplx commented Feb 22, 2024

Any hopes of getting this fixed anytime soon? 🤞

Would like to have an ETA for that. v2beta2 is being removed on GKE by 30th March (previous date was 29th Feb). We've started using this chart recently and shouldn't be that bad to move to another one, but prefer not to do.

Just in case helps, I've duplicated this as #463 for fixing conflicts

@yakir-shriker
Copy link

When will it merge?
EKS 1.29 cant use helm on fluentd since the deprecation.

Copy link
Collaborator

@dioguerra dioguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no definition that you only generic functions are part of the _helpers.
IMO it's just needing to change files if you want to see what it is and keeping things contained as you would do with normal code.

@dioguerra dioguerra merged commit e6aef88 into fluent:main Feb 27, 2024
2 checks passed
@dioguerra
Copy link
Collaborator

@ALL Anything else you would find has priority to be fixed/added?

@OmarHawk
Copy link

@ALL Anything else you would find has priority to be fixed/added?

#424 prevents us from any easy update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated api in fluentd helm chart templates
9 participants