-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fluentd): conditionally update deprecated API for HPA #363
Conversation
Signed-off-by: Michael McLeroy <[email protected]>
👍 Works for me. I have tried and tested this fix and it works great for me. Thank You. |
Any hopes of getting this fixed anytime soon? 🤞 |
Would like to have an ETA for that. v2beta2 is being removed on GKE by 30th March (previous date was 29th Feb). We've started using this chart recently and shouldn't be that bad to move to another one, but prefer not to do. Just in case helps, I've duplicated this as #463 for fixing conflicts |
When will it merge? |
Signed-off-by: Diogo Guerra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no definition that you only generic functions are part of the _helpers.
IMO it's just needing to change files if you want to see what it is and keeping things contained as you would do with normal code.
@ALL Anything else you would find has priority to be fixed/added? |
Closes #345
In Fluentd chart, upgrades HPA to v2 when Kubernetes cluster is not < 1.23