This repository has been archived by the owner on May 17, 2019. It is now read-only.
docs: Document what occurs if the retry count exceeds the limit. #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation, all the data in the output queue will be discarded if it fails to write out a chunk within the retry limit. Since this event necessarily entails a (possibly huge) data loss, we definitely need to document the behaviour in a clear way. This patch adds the documentation to the buffer-plugin-overview page.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the current implementation, all the data in the output queue will
be discarded if it fails to write out a chunk within the given retry limit.
Since this event necessarily entails a (possibly huge) data loss, we
definitely need to document the behaviour in a clear way.
This patch adds the documentation to the buffer-plugin-overview page.
Note
This patch is a part of #427.