Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support placeholder for s3_bucket #360

Closed
wants to merge 1 commit into from

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Dec 10, 2020

Closes: #350

e.g.

 s3_bucket test_${tag}
 <buffer tag>
  @type file
  path foo
 </buffer>

@kenhys kenhys force-pushed the support-bucket-placeholder branch from eba74b0 to ececc3d Compare December 10, 2020 06:02
@kenhys
Copy link
Contributor Author

kenhys commented Dec 10, 2020

This is a PoC PR. need more fix.

Closes: fluent#350

e.g.

 s3_bucket test_${tag}
 <buffer tag>
  @type file
  path foo
 </buffer>

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys force-pushed the support-bucket-placeholder branch from ececc3d to 8d8927d Compare December 10, 2020 08:54
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days

@github-actions github-actions bot added the stale label Jul 6, 2021
@kenhys kenhys removed the stale label Jul 6, 2021
@kenhys
Copy link
Contributor Author

kenhys commented Jul 8, 2021

#363 is another approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When s3_bucket is defined dynamically it is not created when value changes
1 participant