Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_aws: add more IMDS categories #9727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

commiterate
Copy link

@commiterate commiterate commented Dec 16, 2024

Add more IMDS categories.

Excluding the EC2 Auto Scaling target lifecycle state (autoscaling/target-lifecycle-state) from the feature request since the AWS filter seems to assume that IMDS data is immutable. We can just make the process that polls it log the state to stdout (for systemd-journald) or syslog to correlate on-system events.

Note that dedicated host ID (and other metadata, both existing and new) may also be mutable due to live migration.

When a degradation is detected on a Dedicated Host that is enabled for host maintenance, we automatically allocate a replacement Dedicated Host in your account. The replacement Dedicated Host receives a new host ID, but retains the same attributes as the original Dedicated Host, including:

  • Auto placement settings
  • Availability Zone
  • Dedicated Host Reservation association
  • Host affinity
  • Host maintenance settings
  • Host recovery settings
  • Instance type
  • Tags

Once the replacement host has been allocated, we migrate the instances using either live migration host maintenance or reboot-based host maintenance, depending on the instance.

https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/dedicated-hosts-maintenance-basics.html

Fixes #9640.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

fluent/fluent-bit-docs#1530

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@commiterate commiterate force-pushed the add_more_imds_categories branch from b51d689 to 398a519 Compare December 16, 2024 03:05
@edsiper
Copy link
Member

edsiper commented Dec 18, 2024

cc: @PettitWesley @matthewfala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters – AWS Metadata – Support Additional IMDS Instance Metadata Categories
2 participants