-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bin: config: Provide maxstdio option for increasing I/O limit on Windows #9707
base: master
Are you sure you want to change the base?
Conversation
ccd1d52
to
c5a552f
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
c5a552f
to
cc0a9e3
Compare
@cosmo0920 we don't do ulimit stuff in Fluent Bit, why should we do it for Windows ? (maybe we just need to update the docs for windows users ?) |
Is this limit something that can actually be changed at a system configuration level on Windows? This is the MS doco about the setter function: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/setmaxstdio?view=msvc-170 . It seems to be specifically something that's part of the Microsoft C runtime library (CRT). There's some info here saying that the limit can be further stretched if you use specific Win32 calls directory rather than this C runtime library: https://stackoverflow.com/questions/870173/is-there-a-limit-on-number-of-open-files-in-windows/4276338#4276338 |
In Windows, we need to set up the ulimit like limit via |
With default limit of I/O on Windows is somewhat small for large amount of log volume environment.
I provide an option to set up this limit up to 2048.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1528
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.