Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose hold, unhold and blind transfer #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Mazuh
Copy link
Contributor

@Mazuh Mazuh commented May 7, 2020

about #13

@Mazuh Mazuh requested review from jchavanton and hjhixon May 7, 2020 03:48
@Mazuh
Copy link
Contributor Author

Mazuh commented May 7, 2020

I tried to make a few tests using the demo numbers (the ones available on the app by npm start) but I couldn't... the hold fails and cancels the call, while the transfer says that REFER is not allowed.

@jchavanton
Copy link
Contributor

Hi @Mazuh I found a problem where hangup is not working anymore in index.html

You can reproduce by calling Freeswitch and trying to hangup

stable :
https://demo.webrtc.flowroute.com/fr.html?cache_invalidate=xxx
this branch :
https://demo.webrtc.flowroute.com/dev.html?cache_invalidate=xxx

@jchavanton
Copy link
Contributor

When I try to hangup, are you not facing the same problem ?
I copied index.html

dev.html?cache_invalidate=xxx:141 Uncaught TypeError: Cannot read property 'call_id' of null
    at FlowrouteClient.handleCallAction [as onCallAction] (dev.html?cache_invalidate=xxx:141)
    at RTCSession.eval (FlowrouteClient.js:477)
    at RTCSession.emit (events.js:146)
    at RTCSession._ended (RTCSession.js:3442)
    at RTCSession.terminate (RTCSession.js:929)
    at FlowrouteClient.hangup (FlowrouteClient.js:250)
    at HTMLButtonElement.doHangup (dev.html?cache_invalidate=xxx:86)

@prinze77
Copy link

I confirm the error

@jchavanton
Copy link
Contributor

@Mazuh sorry I did not notice that you where having hard time to test on our servers.
We may need another server in staging.

@jchavanton
Copy link
Contributor

@Mazuh is you can fix the problem with hangup @prinze77 could test the feature, I will simply test that there is not regression, we will most likely not support REFER in the near future.

Does this makes sense to you guys ?

@prinze77
Copy link

Testing the feature

@prinze77
Copy link

prinze77 commented May 12, 2020

Looks like blind transfer, mute and unmute works perfect.
@jchavanton what you mean you will stop the support of REFER then how
I finished the first stable version of UI that we talked earlier https://github.com/prinze77/react-softphone
If we implement attended transfer and call queue of hold 3 calls i will use this lib in https://github.com/prinze77/react-softphone.

@jchavanton
Copy link
Contributor

jchavanton commented May 13, 2020

What I meant is that our provided server side infrastructure is not and that we will not support it soon enough to validate this new feature on it.
However, we want to make sure existing features are still working well before merging.
Thanks for your testing, hopefully this feature will be in soon.

Thanks for sharing you UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants