Configurable lifetime for static files #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new environment variable NGINX_STATIC_FILES_LIFETIME which allows for configuration of the cache lifetime controlled through the HTTP response's "expires" header. The default expiration time is now 30 days. Apart from Flow's static resources, additional files in the top directory are now covered (favicon.ico, apple-touch-icon.* etc). Resolves #7
|
Ah, this also fixes the issue in Local Beach where requests to non-existing static files would end up triggering a request in Flow / Neos. Now missing static files just end up in a 404 directly. |
kdambekalns
reviewed
May 4, 2022
|
I will merge and test this in a beta setup and don't communicate the variable names to customers yet, to see if the cache lifetime configuration works in production as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new environment variable
NGINX_STATIC_FILES_LIFETIME which allows for configuration of the
cache lifetime controlled through the HTTP response's "expires"
header. The default expiration time is now 30 days.
Apart from Flow's static resources, additional files in the top
directory are now covered (favicon.ico, apple-touch-icon.* etc).
Resolves #7