Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cache lifetime for static files configurable #7

Open
robertlemke opened this issue May 4, 2022 · 1 comment · Fixed by #8
Open

Make cache lifetime for static files configurable #7

robertlemke opened this issue May 4, 2022 · 1 comment · Fixed by #8
Assignees
@robertlemke @kdambekalns
Labels
customer input feature suggestion or bug report collected from existing or potential customers (source) enhancement enhances an existing feature or functionality (improvements)

Comments

@robertlemke
Copy link
Member

The cache lifetime sent in an HTTP response as the "expires" header should be configurable via an environment variable.
@robertlemke robertlemke added customer input feature suggestion or bug report collected from existing or potential customers (source) enhancement enhances an existing feature or functionality (improvements) labels May 4, 2022
@robertlemke robertlemke self-assigned this May 4, 2022
robertlemke added a commit that referenced this issue May 4, 2022
@robertlemke
Configurable lifetime for static files
5b3435e 
This change introduces a new environment variable
NGINX_STATIC_FILES_LIFETIME which allows for configuration of the
cache lifetime controlled through the HTTP response's "expires"
header. The default expiration time is now 30 days.

Apart from Flow's static resources, additional files in the top
directory are now covered (favicon.ico, apple-touch-icon.* etc).

Resolves #7
@robertlemke robertlemke linked a pull request May 4, 2022 that will close this issue
Configurable lifetime for static files #8
Merged
@robertlemke robertlemke mentioned this issue May 4, 2022
Merged
@robertlemke robertlemke reopened this May 5, 2022
@robertlemke
Copy link
Member Author

The cache lifetime I set (30d) is too short – Google Lighthouse wants at least half a year.

And we will need changes in the Google Cloud Storage plugin in order to achieve proper cache lifetimes for persistent resources (see flownative/flow-google-cloudstorage#32).

robertlemke added a commit that referenced this issue May 5, 2022
@robertlemke
Set Cache-Control header for proxied GCS resources
099f04c 
The "expires" statement does not seem to have an effect – the lifetime
provided by Google always won. However, providing Cache-Control might
work and solve as a hotfix for flownative/flow-google-cloudstorage#32

#7
robertlemke added a commit that referenced this issue May 5, 2022
@robertlemke
Increase default cache lifetime for static files
aeb16a1 
Google does not consider a lifetime of 30 days as long enough, but
6 months should work fine.

#7
robertlemke added a commit that referenced this issue May 5, 2022
@robertlemke
Try an alternative for GCS cache-control
ccc6705 
#7
robertlemke added a commit that referenced this issue May 5, 2022
@robertlemke
Use more_set_headers for GCS cache-control headers
76d975a 
#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertlemke robertlemke

@kdambekalns kdambekalns

Labels
customer input feature suggestion or bug report collected from existing or potential customers (source) enhancement enhances an existing feature or functionality (improvements)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configurable lifetime for static files flownative/docker-nginx
2 participants
@robertlemke @kdambekalns