Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a signal subscription creation bug #3920

Conversation

robert-gurol-ebcont
Copy link

@robert-gurol-ebcont robert-gurol-ebcont commented Jul 11, 2024

Fixes a bug where for the second process you start, signal event processing would happen differently.
E.g., the scope would always be null for the second process (unless the BPMN model cache runs out in the mean time).

Affects Flowable 6.8.1, 7.0.1

Workaround without this fix:
Signal ID and name must be the same, e.g.
<bpmn:signal id="terminate_product" name="terminate_product" flowable:scope="processInstance" />

Check List:

  • Unit tests: YES / NO / NA
    • (as stated elsewhere, I would like to add some, but I need a bit of help getting started - e.g. a pointer to existing test classes that I could extend with 1 or two test cases)
  • Documentation: NA
    • (should not be necessary for a simple bugfix)

@robert-gurol-ebcont
Copy link
Author

robert-gurol-ebcont commented Jul 11, 2024

TODOs

  • check if any unit tests fail
    • if yes, check if this is not a bug, but a feature
      • if feature, reconsider MR
      • if bug, adjust unit test
    • if not, add own unit test(s)
      • Migration:
        • migrate 2 process instances with Signal definitions that have a non-null flowable:scope
        • check that both processes' event subscriptions have a non-null configuration (scope)
      • Process start:
        • start 2 process instances with Signal definitions that have a non-null flowable:scope
        • check that both processes' event subscriptions have a non-null configuration (scope)
      • ℹ️ I created an issue where I ask for help to get started

EDIT:

  • goes through: mvn clean install -DskipTests -DskipITs
  • goes through: mvn verify -pl modules/flowable-engine
    [WARNING] Tests run: 3681, Failures: 0, Errors: 0, Skipped: 6

fix a bug where for the second process
you start, signal processing would happen differently
(e.g. scope would always be null)
@tijsrademakers
Copy link
Contributor

Thank you for the PR, but there are no unit tests showing what this fixes exactly. Therefore closing the PR. Please create a new PR with unit tests if you would like to get this reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants