Remove deprecated Flowable code

modules/flowable-bpmn-converter/src/main/java/org/flowable/bpmn/converter/IndentingXMLStreamWriter.java

@@ -36,41 +36,6 @@ public IndentingXMLStreamWriter(XMLStreamWriter writer) {
         super(writer);
     }
 
-    /**
-     * Return the current indent step.
-     * 
-     * <p>
-     * Return the current indent step: each start tag will be indented by this number of spaces times the number of ancestors that the element has.
-     * </p>
-     * 
-     * @return The number of spaces in each indentation step, or 0 or less for no indentation.
-     * @see #setIndentStep(int)
-     * 
-     * @deprecated Only return the length of the indent string.
-     */
-    @Deprecated
-    public int getIndentStep() {
-        return indentStep.length();
-    }
-
-    /**
-     * Set the current indent step.
-     * 
-     * @param indentStep
-     *            The new indent step (0 or less for no indentation).
-     * @see #getIndentStep()
-     * 
-     * @deprecated Should use the version that takes string.
-     */
-    @Deprecated
-    public void setIndentStep(int indentStep) {
-        StringBuilder s = new StringBuilder();
-        for (; indentStep > 0; indentStep--) {
-            s.append(' ');
-        }
-        setIndentStep(s.toString());
-    }
-
     public void setIndentStep(String s) {
         this.indentStep = s;
     }

modules/flowable-cmmn-api/src/main/java/org/flowable/cmmn/api/CmmnRepositoryService.java

@@ -172,18 +172,6 @@ public interface CmmnRepositoryService {
      */
     List<DmnDecision> getDecisionsForCaseDefinition(String caseDefinitionId);
 
-    /**
-     * Retrieves the {@link DmnDecision}s associated with the given case definition.
-     *
-     * @param caseDefinitionId
-     *            id of the case definition, cannot be null.
-     *
-     * @deprecated replaced by getDecisionsForCaseDefinition(String caseDefinition)
-     *
-     */
-    @Deprecated
-    List<DmnDecision> getDecisionTablesForCaseDefinition(String caseDefinitionId);
-
     /**
      * Retrieves the {@link FormDefinition}s associated with the given case definition.
      *

modules/flowable-cmmn-api/src/main/java/org/flowable/cmmn/api/DecisionTableVariableManager.java

@@ -21,18 +21,8 @@
 
 public interface DecisionTableVariableManager {
 
-    @Deprecated
-    void setVariablesOnPlanItemInstance(List<Map<String, Object>> executionResult, String decisionKey, PlanItemInstance planItemInstance, ObjectMapper objectMapper);
+    void setVariablesOnPlanItemInstance(List<Map<String, Object>> decisionResult, String externalRef, PlanItemInstance planItemInstance, ObjectMapper objectMapper, boolean multipleResults);
 
-    @Deprecated
-    void setDecisionServiceVariablesOnExecution(Map<String, List<Map<String, Object>>> executionResult, String decisionKey, PlanItemInstance planItemInstance, ObjectMapper objectMapper);
-
-    default void setVariablesOnPlanItemInstance(List<Map<String, Object>> decisionResult, String externalRef, PlanItemInstance planItemInstance, ObjectMapper objectMapper, boolean multipleResults) {
-        setVariablesOnPlanItemInstance(decisionResult, externalRef, planItemInstance, objectMapper);
-    }
-
-    default void setDecisionServiceVariablesOnPlanItemInstance(Map<String, List<Map<String, Object>>> executionResult, String decisionKey, PlanItemInstance planItemInstance, ObjectMapper objectMapper, boolean multipleResults) {
-        setDecisionServiceVariablesOnExecution(executionResult, decisionKey, planItemInstance, objectMapper);
-    }
+    void setDecisionServiceVariablesOnPlanItemInstance(Map<String, List<Map<String, Object>>> executionResult, String decisionKey, PlanItemInstance planItemInstance, ObjectMapper objectMapper, boolean multipleResults);
 
 }

modules/flowable-cmmn-api/src/main/java/org/flowable/cmmn/api/history/HistoricCaseInstanceQuery.java

@@ -116,13 +116,6 @@ public interface HistoricCaseInstanceQuery extends Query<HistoricCaseInstanceQue
      */
     HistoricCaseInstanceQuery includeCaseVariables();
 
-    /**
-     * Limit historic case instance variables
-     * @deprecated no longer needed, this is a noop
-     */
-    @Deprecated
-    HistoricCaseInstanceQuery limitCaseVariables(Integer historicCaseVariablesLimit);
-
     /**
      * Only select historic case instances that are defined by a case definition with the given deployment identifier.
      */

modules/flowable-cmmn-api/src/main/java/org/flowable/cmmn/api/runtime/CaseInstanceQuery.java

@@ -233,13 +233,6 @@ public interface CaseInstanceQuery extends Query<CaseInstanceQuery, CaseInstance
      */
     CaseInstanceQuery endOr();
 
-    /**
-     * Limit case instance variables
-     * @deprecated no longer needed, this is a noop
-     */
-    @Deprecated
-    CaseInstanceQuery limitCaseInstanceVariables(Integer caseInstanceVariablesLimit);
-
     /**
      * Localize case name to specified locale.
      */

modules/flowable-cmmn-converter/src/main/java/org/flowable/cmmn/converter/IndentingXMLStreamWriter.java

@@ -36,41 +36,6 @@ public IndentingXMLStreamWriter(XMLStreamWriter writer) {
         super(writer);
     }
 
-    /**
-     * Return the current indent step.
-     * 
-     * <p>
-     * Return the current indent step: each start tag will be indented by this number of spaces times the number of ancestors that the element has.
-     * </p>
-     * 
-     * @return The number of spaces in each indentation step, or 0 or less for no indentation.
-     * @see #setIndentStep(int)
-     * 
-     * @deprecated Only return the length of the indent string.
-     */
-    @Deprecated
-    public int getIndentStep() {
-        return indentStep.length();
-    }
-
-    /**
-     * Set the current indent step.
-     * 
-     * @param indentStep
-     *            The new indent step (0 or less for no indentation).
-     * @see #getIndentStep()
-     * 
-     * @deprecated Should use the version that takes string.
-     */
-    @Deprecated
-    public void setIndentStep(int indentStep) {
-        StringBuilder s = new StringBuilder();
-        for (; indentStep > 0; indentStep--) {
-            s.append(' ');
-        }
-        setIndentStep(s.toString());
-    }
-
     public void setIndentStep(String s) {
         this.indentStep = s;
     }

modules/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/CmmnEngineConfiguration.java

@@ -3060,22 +3060,6 @@ public CmmnEngineConfiguration setBatchServiceConfiguration(BatchServiceConfigur
         return this;
     }
 
-    /**
-     * @deprecated no longer needed, this is a noop
-     */
-    @Deprecated
-    public CmmnEngineConfiguration setTaskQueryLimit(int taskQueryLimit) {
-        return this;
-    }
-
-    /**
-     * @deprecated no longer needed, this is a noop
-     */
-    @Deprecated
-    public CmmnEngineConfiguration setHistoricTaskQueryLimit(int historicTaskQueryLimit) {
-        return this;
-    }
-
     public InternalHistoryVariableManager getInternalHistoryVariableManager() {
         return internalHistoryVariableManager;
     }
@@ -3085,22 +3069,6 @@ public CmmnEngineConfiguration setInternalHistoryVariableManager(InternalHistory
         return this;
     }
 
-    /**
-     * @deprecated no longer needed, this is a noop
-     */
-    @Deprecated
-    public CmmnEngineConfiguration setCaseQueryLimit(int caseQueryLimit) {
-        return this;
-    }
-
-    /**
-     * @deprecated no longer needed, this is a noop
-     */
-    @Deprecated
-    public void setHistoricCaseQueryLimit(int historicCaseQueryLimit) {
-
-    }
-
     public boolean isSerializableVariableTypeTrackDeserializedObjects() {
         return serializableVariableTypeTrackDeserializedObjects;
     }

modules/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/impl/CmmnRepositoryServiceImpl.java

@@ -149,12 +149,6 @@ public List<DmnDecision> getDecisionsForCaseDefinition(String caseDefinitionId)
         return commandExecutor.execute(new GetDecisionsForCaseDefinitionCmd(caseDefinitionId));
     }
 
-    @Override
-    @Deprecated
-    public List<DmnDecision> getDecisionTablesForCaseDefinition(String caseDefinitionId) {
-        return getDecisionsForCaseDefinition(caseDefinitionId);
-    }
-
     @Override
     public List<FormDefinition> getFormDefinitionsForCaseDefinition(String caseDefinitionId) {
         return commandExecutor.execute(new GetFormDefinitionsForCaseDefinitionCmd(caseDefinitionId));

modules/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/impl/history/HistoricCaseInstanceQueryImpl.java

@@ -722,11 +722,6 @@ public HistoricCaseInstanceQuery includeCaseVariables() {
         return this;
     }
 
-    @Override
-    public HistoricCaseInstanceQuery limitCaseVariables(Integer historicCaseVariablesLimit) {
-        return this;
-    }
-
     @Override
     public HistoricCaseInstanceQuery activePlanItemDefinitionId(String planItemDefinitionId) {
         if (planItemDefinitionId == null) {

modules/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/impl/runtime/CaseInstanceQueryImpl.java

@@ -772,11 +772,6 @@ public CaseInstanceQueryImpl includeCaseVariables() {
         return this;
     }
 
-    @Override
-    public CaseInstanceQuery limitCaseInstanceVariables(Integer caseInstanceVariablesLimit) {
-        return this;
-    }
-
     @Override
     public CaseInstanceQuery locale(String locale) {
         this.locale = locale;

modules/flowable-dmn-engine-configurator/src/test/java/org/flowable/dmn/engine/test/MixedDeploymentTest.java

@@ -67,7 +67,7 @@ public void deploySingleProcessAndDecisionTable() {
             assertThat(definition).isNotNull();
             assertThat(definition.getKey()).isEqualTo("decision1");
 
-            List<DmnDecision> decisionsList = repositoryService.getDecisionTablesForProcessDefinition(processDefinition.getId());
+            List<DmnDecision> decisionsList = repositoryService.getDecisionsForProcessDefinition(processDefinition.getId());
             assertThat(decisionsList)
                     .extracting(DmnDecision::getKey)
                     .containsExactly("decision1");