Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

Reorg to use the same flow --from vim command #29

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Conversation

iamdustan
Copy link
Contributor

Idk what the --from {editor} command is intended to do, but this reorganization allows for more commands to share in the initial flow startup process and get the --from vim command.

The biggest change in here is because the jump-to-def format with and without that command changes.

Output without --from:
/Users/iamdustan/projects/project/app.js:5:3,5:33

Output with --from vim:
File "/Users/dkasten/projects/w2g-web/client/root-action-creators.js", line 5, characters 3-33

@ghost ghost added the CLA Signed label Jul 8, 2016
@mroch
Copy link
Contributor

mroch commented Jul 8, 2016

as you noticed, --from vim and --from emacs change the error format into something that vim and emacs have built-in support for.

maintaining special error printers kind of drives me nuts though :) i would love if it was possible for all clients to consume --json (#15)

@iamdustan
Copy link
Contributor Author

I’m learning all sorts of vimscripty-ness these past two days :)

I started looking into the --json bit. Hope to revisit it soon.

@mroch
Copy link
Contributor

mroch commented Jul 8, 2016

maybe the vim-specific format isn't even necessary, since it's got a custom format in s:flow_errorformat.

what if you changed s:flow_errorformat to support the standard output (with no --from) instead? which format seems easier to parse?

@mroch
Copy link
Contributor

mroch commented Jul 8, 2016

i guess you'd probably need --old-output-format instead, so that's probably not an improvement... trading one special param for another.

@mroch mroch merged commit 15ee964 into flow:master Jul 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants