forked from pedrobaeza/connector-prestashop
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prestashop 1.7.5.0 compatibility #5
Open
qtheuret
wants to merge
120
commits into
flotho:10.0_mig_ps
Choose a base branch
from
qtheuret:10.0-mig-ps-flotho
base: 10.0_mig_ps
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t instead of ConnectorSession
…ernal and to_odoo to to_internal
…o binding model. Import Partners
…bs to prestashop models
(cherry picked from commit 263a0cd)
Export of manufacturer on template was broken due to a probable typo. `id_manufacturer` value was taken using `to_odoo` instead of `to_backend`. (cherry picked from commit 82cf263)
If `backend_record.importable_order_state_ids` is valued we check if current order is in the list. If not, the job fails gracefully. (cherry picked from commit 8365676)
(cherry picked from commit 199eb25)
…tabase store to linked to ps image after export (cherry picked from commit 8e3b16b)
When there is no location with the flag prestashop_synchronized in the location tree, Current behavior: The `location` key in the context is empty then the qty_available is computed for *every* locations/warehouses. Expected behavior: If there is at least one location flagged, use it, otherwise, use all the locations of the tree, starting from the selected location or selected warehouse location. When no location can be found (for instance because user selected a location with a usage different than 'internal'), then it should just fail and not return the stock of all warehouses. Being able to synchronize without activating 'prestashop_synchronized' is important: when used, this feature will trigger an export every time a quant is changed or created, on a large catalog, we might prefer only using the cron to have less frequent updates and less jobs. A second fix is that when a stock_location_id is set on the backend, it should be used, it was only used for the import of stock. (cherry picked from commit 6696ec2)
We already pass the children in 'location', if we don't disable 'compute_child', the qty computation will try to get the children of each child and generates query of 1mio chars. (cherry picked from commit 6e08589)
Stats with 6700 products: Before: 570s After: 28s (cherry picked from commit 22926c7)
It was only applied on export of template quantities. (cherry picked from commit 77d406b)
The add/union operation between recordsets is slow, aggregate the ids in a set and call the browse only once on the complete set is dramatically faster. See guewen/connector-magento#9 (cherry picked from commit 5d617fd)
That may pass the prestashop id insted of the binding id to the exporter That can cause the following problems: * A job Error: Key (id_attribute_group)=(4) is not present in table "prestashop_product_combination_option" * Wrong combination or combination values export or updated * Combination or combination value never exported * Faulty value in fields 'id_attribute_group' leading to data incoherence (cherry picked from commit 767ba36)
… to components folder
This reverts commit 4a78d8c.
Hi @qtheuret , could you please resubmit this PR ? |
merci @qtheuret |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.