createData() - unordered time column fixes #436

florianhartig · Sep 25, 2024 · 5b875f7 · 5b875f7
1 parent 90e4c5f
commit 5b875f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Code/DHARMaIssues/436.R b/Code/DHARMaIssues/436.R
@@ -47,7 +47,7 @@ createData2 <- function(sampleSize = 100, intercept = 0, fixedEffects = 1,
 
   out = list()
 
-  time = sample(1:sampleSize, sampleSize) # change here
+  time = sample.int(sampleSizex) # change here
   x = runif(sampleSize)
   y = runif(sampleSize)
 
@@ -92,16 +92,16 @@ createData2 <- function(sampleSize = 100, intercept = 0, fixedEffects = 1,
     # Autocorrelation
 
     if(!(temporalAutocorrelation == 0)){
-      t = 1:sampleSize             # INCLUDING CODE HERE
-      distMat <- as.matrix(dist(t))
+    #  t = 1:sampleSize             # INCLUDING CODE HERE
+      distMat <- as.matrix(dist(time))
 
       invDistMat <- 1/distMat * 5000
       diag(invDistMat) <- 0
       invDistMat = sfsmisc::posdefify(invDistMat)
 
       temporalError <- MASS::mvrnorm(n = 1, mu = rep(0,sampleSize), Sigma = invDistMat)
 
-      linearResponse = linearResponse + temporalAutocorrelation * temporalError[time] #
+      linearResponse = linearResponse + temporalAutocorrelation * temporalError #
     }
 
 

diff --git a/DHARMa/R/createData.R b/DHARMa/R/createData.R
@@ -33,7 +33,7 @@ createData <- function(sampleSize = 100, intercept = 0, fixedEffects = 1,
 
   out = list()
 
-  time = 1:sampleSize
+  time = sample.int(sampleSize) #change to random order because of issue #436
   x = runif(sampleSize)
   y = runif(sampleSize)