Skip to content

Commit

Permalink
Fix pipeline build error (microsoft#3937)
Browse files Browse the repository at this point in the history
This fixes the recent build errors in the pipelines. The compiler was
complaining about re-throwing an exception with `throw e;` instead of
`throw;`, which messes with the stack trace. Presumably it started
because of a tool update in the agents.

This also fixes a compilation error I'm seeing locally from a member not
being initialized.
  • Loading branch information
florelis committed Jan 11, 2024
1 parent 912438c commit 9dad818
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/AppInstallerRepositoryCore/CompositeSource.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,6 @@ namespace AppInstaller::Repository
Source m_installedSource;
std::vector<Source> m_availableSources;
SourceDetails m_details;
CompositeSearchBehavior m_searchBehavior;
CompositeSearchBehavior m_searchBehavior = CompositeSearchBehavior::Installed;
};
}
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ private void AddProvisionPackage(string releaseTag)
catch (RuntimeException e)
{
this.psCmdlet.WriteDebug($"Failed installing bundle via Add-AppxProvisionedPackage {e}");
throw e;
throw;
}
}

Expand All @@ -219,7 +219,7 @@ private void AddAppInstallerBundle(string releaseTag, bool downgrade)
catch (RuntimeException e)
{
this.psCmdlet.WriteDebug($"Failed installing bundle via Add-AppxPackage {e}");
throw e;
throw;
}
}

Expand Down Expand Up @@ -384,7 +384,7 @@ private void AddAppxPackageAsUri(string packageUri, IList<string> options = null
else
{
this.psCmdlet.WriteError(e.ErrorRecord);
throw e;
throw;
}
}
}
Expand Down

0 comments on commit 9dad818

Please sign in to comment.