Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename activity option #92

Merged
merged 4 commits into from
May 1, 2021
Merged

Conversation

lowtower
Copy link
Contributor

This PR renames the option "activity" to "activity_type" to be more clear and consistent with other options.
Additionally, this PR adds the filter "--activity-type" and other options to the README by running the script update-readme.

@flopp
Copy link
Owner

flopp commented Apr 29, 2021

This could break some existing installations - maybe we should add an alias to be backwards compatible...

@flopp
Copy link
Owner

flopp commented Apr 29, 2021

args_parser.add_argument(["--activity-type", "--activity"], ...) should work, I guess.

@lowtower
Copy link
Contributor Author

To be honest, my initial PR was committed maybe a bit hastily.
With this PR, I want to correct some (in my eyes) messy inconsistencies, which is rather cosmetic than really necessary.
You are right, that this would break existing installations.
It's Your tool - You decide which way to go.
I am fine with both names as options (pushed with commit f27d93e)

@flopp
Copy link
Owner

flopp commented May 1, 2021

Thank you!

@flopp flopp merged commit 0b13e79 into flopp:master May 1, 2021
@lowtower lowtower deleted the rename_activity_option branch May 3, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants