Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional field activity_type as a filter to --from-strava FILE #75

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Add optional field activity_type as a filter to --from-strava FILE #75

merged 1 commit into from
Oct 30, 2020

Conversation

CodeFerriCode
Copy link
Contributor

  • Add a field activity_type to the --from-strava FILE structure, so that user can filter by strava activity type(s)
  • Change some existing README content about --from-strava FILE

@CodeFerriCode CodeFerriCode force-pushed the strava-type-filter branch 2 times, most recently from bd80d88 to 7c32743 Compare October 30, 2020 14:08
@CodeFerriCode CodeFerriCode force-pushed the strava-type-filter branch 2 times, most recently from 13f74fd to 07d4161 Compare October 30, 2020 16:47
@flopp
Copy link
Owner

flopp commented Oct 30, 2020

That's a great addition - thanks!

@flopp flopp merged commit 0e5b6d9 into flopp:master Oct 30, 2020
@CodeFerriCode CodeFerriCode deleted the strava-type-filter branch October 31, 2020 01:08
@CodeFerriCode CodeFerriCode mentioned this pull request Nov 1, 2020
Merged
@CodeFerriCode CodeFerriCode mentioned this pull request Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihong0618 yihong0618 yihong0618 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodeFerriCode @flopp @yihong0618