Move setup instruction to top and improve Dockerfile #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorian93
changed the title
|
Thank you for improving the situation. Your changes look good, I will merge them as-is. |
|
If you want to continue with containers, please go ahead - I don't have much experience in this area. |
|
Nice, that provides me with the necessary motivation to go even a little further. Thanks! Love the project by the way! Exactly what I need to show off my Inline Skating. 💪 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me an embarrassing amount of time to find the setup instructions.
So I merely propose to put the setup instructions on the top of the README, like most projects do.
Due to my not being too used to GitHub, I accidentally added some changes to the Dockerfile in this PR.
Before cleaning things up, @flopp please do let me know if this is something that you would be interested in. Then I will gladly proceed and work on the container topic and polish it.