Buzzer cli command #4006
Draft
Buzzer cli command #4006
+651
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanbarsukov
requested review from
skotopes,
DrZlo13,
hedger,
gsurkov,
nminaylov,
gornekich,
Astrrra and
Skorpionm
as code owners
ivanbarsukov
force-pushed
the
buzzer_command
branch
from
768c5c4 to
3645dd1
Compare
skotopes
requested changes
Dec 23, 2024
| @@ -97,3 +116,75 @@ bool args_read_hex_bytes(FuriString* args, uint8_t* bytes, size_t bytes_count) { | |||
|
|
|||
| return result; | |||
| } | |||
|
|
|||
| bool args_read_time(FuriString* args, uint32_t* value, const char* default_unit) { | |||
There was a problem hiding this comment.
Looks like time is not a right word, duration maybe? It will be nice to take a look into other standard libraries and pick common term for the thing.
| * @param note_name The name of the note (e.g., "A4", cs5") | ||
| * @return The frequency of the note in Hz, or 0.0 if the note name is invalid | ||
| */ | ||
| extern float note_frequency(const char* note_name); |
There was a problem hiding this comment.
Function naming. See coding convention for details.
| @@ -525,6 +658,7 @@ void cli_commands_init(Cli* cli) { | |||
|
|
|||
| cli_add_command(cli, "vibro", CliCommandFlagDefault, cli_command_vibro, NULL); | |||
| cli_add_command(cli, "led", CliCommandFlagDefault, cli_command_led, NULL); | |||
| cli_add_command(cli, "buzzer", CliCommandFlagDefault, cli_command_buzzer, NULL); | |||
There was a problem hiding this comment.
We kinda low on free flash memory, adding this feature directly into firmware looks kinda bad.
There is a chance that we will postpone this PR till @portasynthinca3 finish cli refactoring, so we can move non essential things into external apps.
|
Un-draft when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
buzzercli commandVerification
buzzer freq 659orbuzzer note e5for playing e5 for 100 ms (default value)buzzer freq 659 5sorbuzzer note e5 5sfor playing e5 for 5 sbuzzer freq 659 0orbuzzer note e5 0for playing e5 in background and thenbuzzer offto turn it offChecklist (For Reviewer)