[JS] Make sdk.js serialport selection more universal. #3999
+8
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
It's clear that it can't find the flipper. The code searching for ports which 'serialNumber' starts with "flip_", but in windows it the port looking like this:
It shows that the serial number is not starting with 'flip_'.
Another problem with the code is that checking for
if (!flippers)
is useless because when we create the array, a line above it should check for its length instead.Also, when multiple flippers are connected and found when calling the prompts and assigning it to the port, it is simply not initialized yet. It will be initialized a few lines later.
I think it would be much better if the user has to define the COM port all the time they want to run on the device.
Verification
Checklist (For Reviewer)